Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setup for development with docker #523

Merged
merged 2 commits into from
Nov 10, 2017
Merged

Fix setup for development with docker #523

merged 2 commits into from
Nov 10, 2017

Conversation

wvengen
Copy link
Member

@wvengen wvengen commented Oct 30, 2017

This completes #449 and #491. Reorganizes development and production docs somewhat, and brings back the development setup using docker. It could be improved, but I think this is already a small step forward.

After this is merged, the wiki page Deployment notes may need updated links.

@wvengen wvengen added this to the 4.6 milestone Oct 30, 2017
@wvengen wvengen changed the title Fix setup for development with docker [WiP] Fix setup for development with docker Oct 31, 2017
@wvengen
Copy link
Member Author

wvengen commented Nov 1, 2017

This uid hack may still be useful, keeping that as a later improvement.

@wvengen wvengen changed the title [WiP] Fix setup for development with docker Fix setup for development with docker Nov 1, 2017
Copy link
Member

@paroga paroga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i didn't check every detail and tried it myself

version: '2'
services:

web:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to align this with our foodcoops.net setup

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok with that.

services:

web:
extends: worker
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why does web extend worker and not the other way around?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because ports would be added creating a conflict. Need to rework setup to avoid this issue, but I'd like to resolve the current non-working docker-based dev setup asap.

- QUEUE=foodsoft_notifier
- TEST_DATABASE_URL=mysql2://root:secret@mariadb/test?encoding=utf8

mailcatcher:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see not configuration sending the mails to this container

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took same approach as before, where current configuration detects docker environment variables and connects to mailcatcher. Later we can change this to a proper smtp url.

@wvengen
Copy link
Member Author

wvengen commented Nov 10, 2017

Ok to merge? I'll do so today without response.

@wvengen wvengen merged commit 5e4f3fb into master Nov 10, 2017
@wvengen wvengen deleted the feature/docker-dev branch November 10, 2017 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants