Add method to parse bank transactions as JSON #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wvengen
reviewed
Feb 23, 2021
app/models/bank_account.rb
Outdated
| return nil if content.empty? | ||
| data = JSON.parse content, symbolize_names: true | ||
|
|
||
| booked = data.try(:fetch, :transactions, nil).try(:fetch, :booked, nil) || [] |
There was a problem hiding this comment.
Do you agree that this use of try reduces readability?
What about:
return nil if data.empty?
booked = data.fetch(:transactions, {}).fetch(:booked, [])
|
|
||
| def parse_account_information_amount(value) | ||
| value && value[:amount].to_f | ||
| end |
There was a problem hiding this comment.
It seems to me that this doesn't really belong in the model, but in an importer class that takes the file and updates the database.
wvengen
reviewed
Feb 24, 2021
| end | ||
|
|
||
| @bank_account.balance = parse_account_information_amount(balance) || @bank_account.bank_transactions.sum(:amount) | ||
| @bank_account.import_continuation_point = booked.first.try(:fetch, :entryReference, nil) |
There was a problem hiding this comment.
booked.first&.fetch(:entryReference, nil)
|
|
||
| def last_transaction_date | ||
| bank_transactions.order(date: :desc).first.try(:date) | ||
| end |
There was a problem hiding this comment.
I'm a little hesitant, because it invites developers to use the method, and it can't be preloaded.
That said, it makes sense to put it here, so let's leave it.
There was a problem hiding this comment.
Also, I think we can use the &. operator, that in my view is more readable (and less lenient):
bank_transactions.order(date: :desc).first&.date
This implements parsing of the Account Information Service format as defined in the Berlin Group Group NextGenPSD2 XS2A Framework, which is widely used across various European banks. This is a first step to replace the current bank import features with a standardized JSON interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements parsing of the Account Information Service format as
defined in the Berlin Group Group NextGenPSD2 XS2A Framework, which
is widely used across various European banks.
This is a first step to replace the current bank import features with
a standardized JSON interface.