-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve various dl-horizontal views #840
Improve various dl-horizontal views #840
Conversation
Rework of the page of a single invoice - using dl for better readability - formatting dates (created_at without time info, or is that important?) - formatting note to support line breaks - hide attachment line if none attached
supporting line breaks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small issue, otherwise good to go. thanks!
- sum = order.sum | ||
- total += sum | ||
= ', ' if index > 0 | ||
= link_to format_date(order.ends), new_finance_order_path(order_id: order) #, style: "margin-right: 0.2em;" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please remove the unnecessary comment
Just a note for the foodcoopsat fork: Please be aware that this collides with this commit (number of indents has to aligned) |
sorry I missed the change for the |
The date was not formatted with |
we can change |
I raised the width of dl-horizontal titles (used on pages like suppliers/show, group_orders/show, and here finance/invoices/show as well), as some titles, esp. in German, were cut off before. I'm not sure if this could have negative effects on small screens like on mobile devices. I guess there has been a reason this wasn't changed.
Also I added some 'line spacing' via margin-bottom to increase the readability of those pages.
With these changes, we could also use dl-horizontal for the invoices/show page, which would again improve readability and make it easier to compare dates, amounts, deposit etc.