Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add home controller test #972

Merged
merged 5 commits into from
Mar 25, 2023
Merged

Add home controller test #972

merged 5 commits into from
Mar 25, 2023

Conversation

yksflip
Copy link
Member

@yksflip yksflip commented Dec 5, 2022

Co-authored-by: viehlieb pf@pragma-shift.net
Co-authored-by: Tobias Kneuker tk@pragma-shift.net

@yksflip yksflip mentioned this pull request Dec 5, 2022
Draft
1 task
@yksflip yksflip force-pushed the 8_increase_test_coverage_controllers_home branch from 44583c3 to 26e5d0a Compare December 5, 2022 15:26
@wvengen
Copy link
Member

wvengen commented Dec 12, 2022

At first glance, great! I can imagine this is useful especially for the Rails upgrade. 👍

@yksflip
Copy link
Member Author

yksflip commented Jan 2, 2023

thanks wvengen!
@paroga what do you think? Anything needed to get this merged? :)

@kidhab kidhab mentioned this pull request Feb 6, 2023
Closed
@yksflip yksflip mentioned this pull request Feb 17, 2023
Merged
10 tasks
@yksflip @Viehlieb @t3k4y
Add home controller test
f2965e6 
Co-authored-by: viehlieb <pf@pragma-shift.net>
Co-authored-by: Tobias Kneuker <tk@pragma-shift.net>
lentschi
lentschi reviewed Mar 5, 2023
View reviewed changes
Copy link
Contributor

@lentschi lentschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me in general; added some minor remarks

spec/controllers/home_controller_spec.rb Outdated Show resolved Hide resolved
Gemfile Outdated Show resolved Hide resolved
spec/controllers/home_controller_spec.rb Outdated Show resolved Hide resolved
app/controllers/home_controller.rb Outdated Show resolved Hide resolved
spec/spec_helper.rb Outdated Show resolved Hide resolved
@yksflip yksflip force-pushed the 8_increase_test_coverage_controllers_home branch 2 times, most recently from 3f28f81 to 4ee0f76 Compare March 6, 2023 11:51
@yksflip yksflip force-pushed the 8_increase_test_coverage_controllers_home branch from 4ee0f76 to 54e11dc Compare March 6, 2023 11:57
@yksflip yksflip requested a review from lentschi March 6, 2023 12:01
lentschi
lentschi requested changes Mar 25, 2023
View reviewed changes
Gemfile.lock Outdated Show resolved Hide resolved
@yksflip yksflip merged commit 503ed6c into foodcoops:master Mar 25, 2023
@wvengen
Copy link
Member

wvengen commented Mar 25, 2023

Hooray! 🎉

@yksflip yksflip added this to the 4.8 milestone Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lentschi lentschi lentschi requested changes

Assignees
No one assigned
Labels
None yet
Projects
Foodsoft roadmap
Archived in project
Milestone
4.8
Development

Successfully merging this pull request may close these issues.
3 participants
@yksflip @wvengen @lentschi