Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Turkish support with help of ChatGPT #988

Closed
wants to merge 3 commits into from
Closed

Added Turkish support with help of ChatGPT #988

wants to merge 3 commits into from

Conversation

nurp
Copy link
Contributor

@nurp nurp commented Mar 29, 2023

No description provided.

@wvengen
Copy link
Member

wvengen commented Mar 30, 2023

Thank you for your translation!

As a general translation thing: how much did you check the ChatGPT output? It requires care and thought to translate a user-interface well and consistently. An automated bot is not guaranteed to do this well, whatever AI you may use. Especially domain-specific terms (like "Ordergroup", "User", "Apple points", "Order", "Supplier", "Article", and more) usually need some thought.

Also, did you check how the translations look while running Foodsoft?
There used to be a translation instance of Foodsoft where your online translations could be viewed directly, but unfortunately we don't have this anymore. So it is important - especially for a first time full translation, to manually check how everything looks. Does it fit in the available space? Do terms make sense in context? Is the UI still understandable?

@nurp
Copy link
Contributor Author

nurp commented Mar 31, 2023

I looked and in general ChatGPT did a great work but I didn't check everything because my aim was to have a first version so that I can run it online to test drive with other volunteers and then release a fixed version for everything.
I don't know any way other than running this Turkish version in Gitpod, and with Gitpod, it goes offline once I turn off my computer.
I'll ask foodcoops.net if they can pull a version from my fork, maybe then other Turkish collaborators can check with me.
For now, you can decline then.

@nurp
Copy link
Contributor Author

nurp commented Mar 31, 2023

I also didn't understand domain specific keywords. What should I look for, for "Ordergroup" for example? ChatGPT left those special keywords as they are. ie:
description2: "%{ordergroups} %{article_count} adet ürün sipariş verdi,

@wvengen
Copy link
Member

wvengen commented Mar 31, 2023

I looked and in general ChatGPT did a great work but I didn't check everything because my aim was to have a first version so that I can run it online to test drive with other volunteers and then release a fixed version for everything.

👍

I'll ask foodcoops.net if they can pull a version from my fork, maybe then other Turkish collaborators can check with me.

That will not be an option, foodcoops.net runs the latest stable version / master of Foodsoft.
Please feel free to suggest on the forum your need for hosting a version of Foodsoft for translating. If there are more users that want this, that increases chances that this will happen eventually. For now, I think you will need to arrange that yourself.

Great to hear you've run this with Foodsoft and looked at the UI 👍

I also didn't understand domain specific keywords. What should I look for, for "Ordergroup" for example?

Yes. Translators often create list of terminology, how specific words/concepts are translated.
See https://foodcoops.readthedocs.io/en/latest/ for other documentation where you will find these concepts - though somehow they are sometimes named differently from what Foodsoft itself uses (e.g. cellar vs. stock).

Special keywords with a % sign indeed need to be retained, they are replaced with numbers or another (translated) text.

I suppose you've seen the wiki on Translation.

@kidhab
Copy link
Contributor

kidhab commented Apr 12, 2023

#995 was merged. I assume we can close this MR, can't we?

@nurp nurp closed this Apr 13, 2023
@nurp
Copy link
Contributor Author

nurp commented Apr 13, 2023

Is it normal that it says "Closed with unmerged commits"?

@kidhab
Copy link
Contributor

kidhab commented Apr 13, 2023

You created another MR (#995) and that was merged. So if you close this one it's indeed a MR with unmerged commits. Do you want the changes from this MR also get merged? I assumed that the other changes are quite newer because you explicitly stated that you double checked your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants