Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify an URL to redirect after logout via settings #989

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

kidhab
Copy link
Contributor

@kidhab kidhab commented Mar 29, 2023

This change make it possbile to specify an URL via logout_redirect_url at config/app_config.yml. After logging out the application redirects to this URL.

We use is to redirect the logout of the Demo instance to the info page.

Maybe this is also useful for other foodcoops.

@yksflip
Copy link
Member

yksflip commented Mar 29, 2023

Great, thank you! Maybe it would be good to have it in the app_config.yml.SAMPLE too?

@kidhab kidhab force-pushed the redirect_at_logout branch from fe59308 to f360f76 Compare March 29, 2023 17:18
@kidhab
Copy link
Contributor Author

kidhab commented Mar 29, 2023

Great, thank you! Maybe it would be good to have it in the app_config.yml.SAMPLE too?

done.

@yksflip yksflip merged commit c01c16e into foodcoops:master Mar 30, 2023
@wvengen
Copy link
Member

wvengen commented Mar 30, 2023

It sounds like it could be useful to be able to configure in the configuration screen - I think most settings are, just not those that are security sensitive (like, which parts can be overridden from the database). This helps self-service e.g. at foodcoops.net.

And I'd like to note this for the record, so that when others add new config options (that would be useful for foodcoops to set without help of an admin), they would consider adding the UI part as well.

Anyway, great idea, feel free but not pressed to implement it. Already an improvement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants