Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some numbers not localized (decimal point/comma) #60

Closed
twothreenine opened this issue Apr 15, 2024 · 1 comment
Closed

Some numbers not localized (decimal point/comma) #60

twothreenine opened this issue Apr 15, 2024 · 1 comment
Assignees
Labels
bug Something isn't working low-priority Minor issue with little consequences

Comments

@twothreenine
Copy link
Contributor

twothreenine commented Apr 15, 2024

In German, these numbers should be with decimal comma instead of decimal point:
grafik

The unit content (in brackets) also affects the order placement menu.
grafik

@twothreenine twothreenine added the low-priority Minor issue with little consequences label Apr 15, 2024
@lentschi lentschi self-assigned this Apr 19, 2024
@lentschi lentschi added the bug Something isn't working label Apr 19, 2024
@lentschi lentschi added this to the Ready for MR milestone Apr 19, 2024
@lentschi
Copy link
Contributor

In German, these numbers should be with decimal comma instead of decimal point

That seems to be a firefox bug:
https://stackblitz.com/edit/stackblitz-starters-wq7ukz?file=index.html

<input type="number" value="1.0">
<input type="number" value="1.3">

<- In Chrome (v123.0.6312.105 with the preferred content language set to German) both those inputs look like this:
grafik

In firefox (124.0.2) the first input (the one with a value of "1.0") uses a dot as a decimal separator for some inexplicable reason:
grafik

I couldn't find that precise bug on bugzilla, but to me it seems to be a bug. (Or at least I don't get why those two inputs should behave differently.)

One could work-around this by fixing the associated rails issue: Not passing zero insignificant zeroes to decimal inputs, but that would be quite some effort as we'd have to either wrap the simple form input logic, or manually custom format the value in each occurrence in the templates, so I'm closing this for now.

The unit content (in brackets) also affects the order placement menu.

That part is fixed. 👍

lentschi added a commit that referenced this issue May 4, 2024
lentschi added a commit that referenced this issue May 4, 2024
lentschi added a commit that referenced this issue May 24, 2024
lentschi added a commit that referenced this issue Jul 26, 2024
lentschi added a commit that referenced this issue Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working low-priority Minor issue with little consequences
Projects
None yet
Development

No branches or pull requests

2 participants