Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show order [management]: Adapt column headings? + append supplier order unit for all articles? #64

Open
twothreenine opened this issue Apr 18, 2024 · 2 comments
Assignees
Milestone

Comments

@twothreenine
Copy link
Contributor

twothreenine commented Apr 18, 2024

Column headings:
"Members" is confusing and was never translated. I suggest changing it to "Total order", or whatever term we agree on in #63.
Same for "Full units" -> "Order result"?

Then for some articles, the supplier order unit isn't shown in the far right column:

  • In case of beer, you wouldn't know if it refers to 20.0 l or 20.0 x Bottle (0.5 l).
  • In case of potatoes, we need it since it differs from the group order unit.
  • For carrots & oyster mushrooms (supplier order unit == group order unit) we don't really need it, I'm unsure if it should be appended for the sake of completeness or omitted to underline it's the same as the group order unit.

grafik

This also applies to the receive menu:
grafik

@lentschi lentschi added this to the Ready for MR milestone Apr 27, 2024
@twothreenine twothreenine self-assigned this Apr 27, 2024
@twothreenine
Copy link
Contributor Author

I thought about the terminology in the column headings across various views, also in regards to upstream/#1016.
My key thoughts:

  • there should be a consistent terminology in the frontend
  • some headings should depend on the order's state

Here are my notes, which go beyond this issue and also beyond the aim of this fork:
Hackathon received etc columns.xlsx

@lentschi lentschi assigned lentschi and unassigned twothreenine Jun 22, 2024
lentschi added a commit that referenced this issue Jun 22, 2024
lentschi added a commit that referenced this issue Jun 22, 2024
@lentschi
Copy link
Contributor

The issue with the missing units is fixed by b38dfb0, the issue with the column renaming/ordering remains, but is not directly related to the fork, so I'll move it to the post-merge milestone.

@lentschi lentschi modified the milestones: Ready for MR, Post-merge Jun 22, 2024
lentschi added a commit that referenced this issue Jul 26, 2024
lentschi added a commit that referenced this issue Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants