Open
Conversation
Contributor
Author
Contributor
Author
Contributor
Author
Collaborator
|
可以直接使用了 Sent from my iPhone
|
Contributor
Author
|
还有优化空间 |
Contributor
Author
|
这个PR等等再合并哈,下周有时间再搞搞 |
Collaborator
|
多余的 commits rebase 合并掉 |
lib/common.js
Outdated
Collaborator
There was a problem hiding this comment.
可以试试 node 自带的 utils https://iojs.org/api/util.html#util_util_isstring_object
Contributor
Author
There was a problem hiding this comment.
nodejs里没有,现在只有iojs里有,等以后新版本应用多了再试。lodash已经优化的不错了
Collaborator
|
isObject 判断,可以使用最高效的方式: 而且我们如果已经判断了不是数组,后面一步也没必要了 |
Contributor
Author
|
lodash里的isObject也是这么做的。你说的几个我再改改看看性能提升 |
…of velocity rendering improves to half of that of nunjucks
Contributor
Author
|
这个还没合 |
Owner
|
ms 邵帅说他再改改,然后我就忘记关注了 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





compilemethod to support simple precompiling. More work should be done to achieve further performance improvement.