Enable Azure Pipelines #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for running these tests in CI. Verified locally with Safari Technology Preview 67: ``` export no_proxy='*' ./wpt run --metadata infrastructure/metadata/ --channel=preview safari infrastructure/ ./wpt run --metadata infrastructure/metadata/ --channel=preview safari_webdriver infrastructure/ ``` With Safari 12 there are still failures, but we'll not use that in CI.
This doesn't work on macOS. Replacement taken from: https://serverfault.com/a/406371
62.5s) This reverts commit 94a33fa.
foolip
force-pushed
the
azure-pipelines
branch
from
409a831 to
63b0e82
Compare
foolip
added a commit
that referenced
this pull request
Oct 21, 2018
Squashed commit of the following: commit 63b0e82 Author: Philip Jägenstedt <philip@foolip.org> Date: Mon Oct 22 00:52:38 2018 +0200 Publish artifacts even on failure commit 2d5ac40 Author: Philip Jägenstedt <philip@foolip.org> Date: Mon Oct 22 00:37:31 2018 +0200 try everything at once commit 765d8b7 Author: Philip Jägenstedt <philip@foolip.org> Date: Sun Oct 21 20:58:59 2018 +0200 try more conditions commit 4294097 Author: Philip Jägenstedt <philip@foolip.org> Date: Sun Oct 21 20:47:36 2018 +0200 try again commit 081f7c2 Author: Philip Jägenstedt <philip@foolip.org> Date: Sun Oct 21 18:00:19 2018 +0200 Change lots of things commit 250ee03 Author: Philip Jägenstedt <philip@foolip.org> Date: Sun Oct 21 17:24:00 2018 +0200 Revert "Drop checkout step to compare speed (was 23.5s)" (new time was 62.5s) This reverts commit 94a33fa. commit 94a33fa Author: Philip Jägenstedt <philip@foolip.org> Date: Sun Oct 21 17:19:10 2018 +0200 Drop checkout step to compare speed (was 23.5s) commit b1a625a Author: Philip Jägenstedt <philip@foolip.org> Date: Sun Oct 21 17:15:53 2018 +0200 Check if checkout depth worked commit a6af121 Author: Philip Jägenstedt <philip@foolip.org> Date: Sun Oct 21 17:10:09 2018 +0200 Add a checkout step to limit initial checkout commit 3ddc985 Author: Philip Jägenstedt <philip@foolip.org> Date: Sun Oct 21 17:09:56 2018 +0200 Try env to show all vars commit b9ba232 Author: Philip Jägenstedt <philip@foolip.org> Date: Sun Oct 21 16:56:21 2018 +0200 Use ./wpt test-jobs (step 1) commit e7f01af Author: Philip Jägenstedt <philip@foolip.org> Date: Sun Oct 21 16:54:54 2018 +0200 Add dash to vmImage Per https://docs.microsoft.com/en-us/azure/devops/pipelines/agents/hosted?view=vsts&tabs=yaml#use-a-microsoft-hosted-agent commit 9018125 Author: Philip Jägenstedt <philip@foolip.org> Date: Sun Oct 21 01:24:53 2018 +0200 try publishing artifacts commit 572df15 Author: Philip Jägenstedt <philip@foolip.org> Date: Sun Oct 21 01:05:25 2018 +0200 Try STP 67 again commit ca10e72 Author: Philip Jägenstedt <philip@foolip.org> Date: Sun Oct 21 00:57:31 2018 +0200 Try reverting to STP 65 commit 7a3c57e Author: Philip Jägenstedt <philip@foolip.org> Date: Sun Oct 21 00:54:21 2018 +0200 fix (?) syntax commit ab8bd14 Author: Philip Jägenstedt <philip@foolip.org> Date: Sun Oct 21 00:52:03 2018 +0200 trigger builds for maste branch only commit e3f1983 Author: Philip Jägenstedt <philip@foolip.org> Date: Sun Oct 21 00:43:08 2018 +0200 Debug safaridriver commit 256ba9d Author: Philip Jägenstedt <philip@foolip.org> Date: Sun Oct 21 00:34:25 2018 +0200 Check if safaridriver works commit d86e282 Author: Philip Jägenstedt <philip@foolip.org> Date: Sat Oct 20 19:09:53 2018 +0200 Azure Pipelines commit 3432729 Author: Philip Jägenstedt <philip@foolip.org> Date: Sat Oct 20 19:30:38 2018 +0200 Avoid the use of `readlink -f` in shell scripts This doesn't work on macOS. Replacement taken from: https://serverfault.com/a/406371 commit b96f5e4 Author: Philip Jägenstedt <philip@foolip.org> Date: Sat Oct 20 12:44:57 2018 +0200 Add expectations for Safari in for infrastructure/ tests In preparation for running these tests in CI. Verified locally with Safari Technology Preview 67: ``` export no_proxy='*' ./wpt run --metadata infrastructure/metadata/ --channel=preview safari infrastructure/ ./wpt run --metadata infrastructure/metadata/ --channel=preview safari_webdriver infrastructure/ ``` With Safari 12 there are still failures, but we'll not use that in CI.
foolip
added a commit
that referenced
this pull request
Oct 21, 2018
foolip
added a commit
that referenced
this pull request
Oct 21, 2018
foolip
added a commit
that referenced
this pull request
Oct 22, 2018
foolip
pushed a commit
that referenced
this pull request
Apr 1, 2019
chromedriver doesn't allow changing Object.prototype to add enumerable
properties, but this test requires setting some values on
Object.prototype. When Object.prototype.a is set to:
{b: {c: 'on proto'}}
chromedriver fails with:
JavascriptErrorException: javascript error (500): Maximum call stack size exceeded
(Session info: chrome=72.0.3626.121)
Remote-end stacktrace:
#0 0x563ff3a32a59 <unknown>
#1 0x563ff39cb7f3 <unknown>
#2 0x563ff38fcd7c <unknown>
#3 0x563ff38ff78c <unknown>
#4 0x563ff38ff5f7 <unknown>
#5 0x563ff38ffbe7 <unknown>
#6 0x563ff38fff1b <unknown>
#7 0x563ff38a3f7a <unknown>
#8 0x563ff3899bf2 <unknown>
#9 0x563ff38a37b7 <unknown>
#10 0x563ff3899ac3 <unknown>
#11 0x563ff38782d2 <unknown>
#12 0x563ff3879112 <unknown>
#13 0x563ff39fe865 <unknown>
#14 0x563ff39ff32b <unknown>
#15 0x563ff39ff70c <unknown>
#16 0x563ff39d940a <unknown>
#17 0x563ff39ff997 <unknown>
#18 0x563ff39e9947 <unknown>
#19 0x563ff3a1a800 <unknown>
#20 0x563ff3a3c8be <unknown>
#21 0x7f3bf4545494 start_thread
#22 0x7f3bf2d58a8f clone
Ran 1 tests finished in 2.0 seconds.
• 0 ran as expected. 0 tests skipped.
• 1 tests had errors unexpectedly
Work around this problem by cleaning up the test environment so
Object.prototype no longer has the override by the time chromedriver
tries to inspect the test result.
While here, fix the other tests to use the t.add_cleanup() function
so they'll cleanup their test environment in case they exit in
some other way besides reaching t.done().
The underlying chromedriver issue is tracked upstream at
https://crbug.com/chromedriver/2555.
Bug: 934844
Change-Id: Id1b4ab2a908bfbc001e2a2d045eeec3ef01c24d9
foolip
pushed a commit
that referenced
this pull request
Oct 6, 2023
This reverts commit 3438f2a59daa31ad1d86777d73e1cff836cef570. Reason for revert: Suspect causing blink_wpt_tests and blink_web_tests failure on Linux Tests (dbg)(1) bot. Failed tests: blink_wpt_tests failed because of: external/wpt/css/css-contain/content-visibility/detach-locked-slot-children-crash.html external/wpt/css/css-contain/content-visibility/element-reassigned-to-skipped-slot.html external/wpt/css/css-contain/content-visibility/element-reassigned-to-slot-in-skipped-subtree.html external/wpt/html/semantics/forms/the-input-element/focus-dynamic-type-change-on-blur.html ...7 more failure(s) (11 total)... blink_web_tests failed because of: accessibility/details-summary-crash.html fast/events/drag-on-removed-slider-does-not-crash.html fast/forms/range/range-type-change-onchange-2.html html/details_summary/details-add-summary.html ...5 more failure(s) (9 total)... First build failure: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/114032/overview Sample log: --- STDERR: #6 0x7fc01bd0361d logging::CheckError::~CheckError() STDERR: #7 0x7fbffd21d08a blink::FlatTreeTraversal::AssertPrecondition() STDERR: #8 0x7fbffd21cfd5 blink::FlatTreeTraversal::Parent() STDERR: #9 0x7fbffd3c2a45 blink::FlatTreeTraversal::AncestorsOf() STDERR: #10 0x7fbffd3d410e blink::(anonymous namespace)::NearestLockedExclusiveAncestor() STDERR: #11 0x7fbffd3d3d17 blink::DisplayLockUtilities::IsInUnlockedOrActivatableSubtree() STDERR: #12 0x7fbfedfabc4b blink::DisplayLockUtilities::ShouldIgnoreNodeDueToDisplayLock() STDERR: #13 0x7fbfedf8b61c blink::AXObject::ToString() STDERR: #14 0x7fbfedf8eccc blink::AXObject::Detach() STDERR: #15 0x7fbfedf512df blink::AXNodeObject::Detach() STDERR: #16 0x7fbfedf2d6a5 blink::AXLayoutObject::Detach() STDERR: #17 0x7fbfedfce51a blink::AXObjectCacheImpl::Remove() STDERR: #18 0x7fbfedfcd998 blink::AXObjectCacheImpl::Remove() STDERR: #19 0x7fbfedfcdd74 blink::AXObjectCacheImpl::Remove() STDERR: #20 0x7fbfedfce992 blink::AXObjectCacheImpl::Remove() STDERR: #21 0x7fbffe6d16be blink::LayoutObject::WillBeDestroyed() --- Original change's description: > [A11y] Reland targeted cached property invalidation > > Relands the following CLS: > * Enhance performance by targeting value updates to specific nodes, commit 704633e6846e44b20c488a3eb98fa43c2c8e4591. > * Don't queue anything for irrelevant attribute changes, commit 2c66a62ed62e601b7a81271e4be4f9e173ce9afc. > * Add comment explaining call to UpdateStyleAndLayoutTreeForNode(), commit 73b9eed3b48bc8ce70de657672755f44a89e7358. > * Ensure cached values not invalidated during the computation of them, commit 4d167a62cd13d5209ecefb664e3690ac955bc559. > * Run a test with --force-renderer-accessibility that used to fail, commit cab7ecd829b24acf677e02f8f118085eaad7f799. > * Simplify code to update cached focusable state, commit 79cb184e5dab5f6084ec78d485bd9496eaa0aaf8. > * Simplify code that invalidates cached values on an AXObject, commit 6df79a50a55fe5cf99d2c50f7308e1236361b771. > > Fixed: 1446864, 1446550, 1434555, 1362758 > Change-Id: I16855bdcb746cb41387b69e1e97ab72ffc47e342 > Cq-Do-Not-Cancel-Tryjobs: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4545510 > Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> > Reviewed-by: Jacques Newman <janewman@microsoft.com> > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1157878} Change-Id: Iefe59fe1933747346eda8827fd683f310d6cddb3 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615927 Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Owners-Override: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Takashi Sakamoto <tasak@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1157993}
foolip
pushed a commit
that referenced
this pull request
May 16, 2024
Since @page border box layout objects aren't in the the layout tree, any code that wants to walk up the tree to find the containing block will be in for a surprise. This would happen if percentage-based @page padding was used [1]. Recomputing padding during painting when we have already done it during layout is rather pointless anyway. Read it out directly from the fragment. [1] #1 blink::LayoutBox::ContainingBlockLogicalWidthForContent() #2 blink::LayoutBoxModelObject::ComputedCSSPadding() #3 blink::LayoutBoxModelObject::PaddingTop() #4 blink::LayoutBoxModelObject::PaddingOutsets() #5 blink::BoxPainterBase::PaintFillLayer() #6 blink::BoxPainterBase::PaintFillLayers() #7 blink::BoxFragmentPainter::PaintBackground() Bug: 40286153 Change-Id: I1e6e92c2ce1d81aab2673ec9a877eac455534102 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5526469 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/main@{#1300711}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.