This repository has been archived by the owner on Dec 1, 2021. It is now read-only.
Add Meteor.settings.validatorStatus0 #317
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfig
force-pushed
the
validatorStatus0
branch
2 times, most recently
from
2180db4 to
533362a
Compare
michaelfig
commented
Mar 13, 2020
| validator.jailed = validatorData.jailed; | ||
|
|
||
| // validatorData.jailed may be undefined in cosmos-sdk v0.39.0. | ||
| validator.jailed = !!validatorData.jailed; |
There was a problem hiding this comment.
@kwunyeung, this single line was the main problem I ran into after the status changes. validatorData.jailed is undefined instead of false. This is a consequence of ibc-alpha moving to protobuf3 instead of Amino.
|
Right. I forgot to update the publications and some interfaces. We will have test cases for the frontend in the coming revamp. I point the PR to the |
By default, set this parameter to 0, so validator status can be 0, 1, 2. For the ibc-alpha branch (and probably sdk v0.39.x), we need to set it to 1, so validator status is 1, 2, 3.
michaelfig
force-pushed
the
validatorStatus0
branch
from
533362a to
2535650
Compare
|
Withdrawn in favour of #357. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi @kwunyeung,
This PR adds a generic
Meteor.settings.validatorStatus0configuration, whosedefault_settings.jsonvalue is 0. That means validator status is 0, 1, or 2.For IBC-alpha, I'm setting this value to 1, so that validator status is 1, 2, 3.
Also, I noticed that
validatorData.jailedisundefinedon the ibc-alpha branch. I've hacked around this in this PR.Fixes #311
Checklist
CHANGELOG.mdfile.Files changedin the Github PR explorer.