Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Cosmos SDK v0.50.x #745

Closed
jmastr opened this issue Jun 20, 2024 · 2 comments
Closed

Support for Cosmos SDK v0.50.x #745

jmastr opened this issue Jun 20, 2024 · 2 comments

Comments

@jmastr
Copy link

jmastr commented Jun 20, 2024

Feature description

Support for Cosmos SDK v0.50.x

Implementation proposal

dadamu added a commit that referenced this issue Jun 25, 2024
## Description

Closes: #745 

<!-- Add a description of the changes that this PR introduces and the
files that
are the most critical to review. -->

---

This PR upgrade juno to v6 then supports cosmos-sdk v0.50.x.

### Author Checklist

*All items are required. Please add a note to the item if the item is
not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type
prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json)
in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch
- [ ] provided a link to the relevant issue or specification
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go
code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable
and please add
your handle next to the items reviewed if you only reviewed selected
items.*

I have...

- [ ] confirmed the correct [type
prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json)
in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
@dadamu
Copy link
Contributor

dadamu commented Jun 25, 2024

Hey, you can try this branch:
https://github.com/forbole/callisto/tree/cosmos/v0.50.x

@jmastr
Copy link
Author

jmastr commented Jun 25, 2024

Thanks man! That is just awesome! Thank you so much!

@jmastr jmastr closed this as completed Jun 25, 2024
Chuiko-GIT pushed a commit to stalwart-algoritmiclab/callisto that referenced this issue Jul 1, 2024
## Description

Closes: forbole#745

<!-- Add a description of the changes that this PR introduces and the
files that
are the most critical to review. -->

---

This PR upgrade juno to v6 then supports cosmos-sdk v0.50.x.

### Author Checklist

*All items are required. Please add a note to the item if the item is
not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type
prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json)
in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch
- [ ] provided a link to the relevant issue or specification
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go
code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable
and please add
your handle next to the items reviewed if you only reviewed selected
items.*

I have...

- [ ] confirmed the correct [type
prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json)
in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants