Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#478,437/starred-menu-animation #540

Merged
merged 4 commits into from
Jan 4, 2022
Merged

#478,437/starred-menu-animation #540

merged 4 commits into from
Jan 4, 2022

Conversation

rachelhox
Copy link
Contributor

@rachelhox rachelhox commented Jan 3, 2022 •
edited
Loading

closes #437 #478

@rachelhox rachelhox requested a review from calvinkei January 3, 2022 08:28
@rachelhox rachelhox changed the title 478/starred-menu-animation 478&&437/starred-menu-animation Jan 3, 2022
@rachelhox rachelhox linked an issue Jan 3, 2022 that may be closed by this pull request
Enhance starred accounts message on the left menu #478
Closed
@rachelhox
Copy link
Contributor Author

Unit Test:
felippenardi/lottie-react-web#21 (comment)

@rachelhox rachelhox changed the title 478&&437/starred-menu-animation #478 #437/starred-menu-animation Jan 3, 2022
@rachelhox rachelhox changed the title #478 #437/starred-menu-animation #478,437/starred-menu-animation Jan 3, 2022
@calvinkei
Copy link
Contributor

we might need a lottie file for light theme @nicoletting

@nicoletting
Copy link

Uploaded, check please 🙇🏻‍♀️
@calvinkei
https://drive.google.com/drive/u/1/folders/13pP_EZv_Rj2LXlLBryf1AqNwbtq07Gka

@calvinkei
Copy link
Contributor

@rachelhox please add design for light theme. thanks!

@calvinkei calvinkei merged commit be7f88c into dev Jan 4, 2022
@calvinkei calvinkei deleted the animation/starred-menu branch January 4, 2022 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calvinkei calvinkei Awaiting requested review from calvinkei

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance starred accounts message on the left menu UI of the Starred Accounts
3 participants
@rachelhox @calvinkei @nicoletting