Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update feats #599

Merged
merged 2 commits into from
Feb 9, 2022
Merged

update feats #599

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
301c1e4
#571
rachelhox Feb 7, 2022
ae38473
#562
rachelhox Feb 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/Layout/LeftMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ const LeftMenu: React.FC<LeftMenuProps> = ({ activeItem, isMenuExpanded, setIsMe
{items.map((item) => {
const selected = item.href === activeItem
return (
<Link key={item.title} href={item.href} passHref>
<Link key={item.title} href={item.href} as={`${item.href}`} passHref>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how does it fix #571 ?

Copy link
Contributor Author

@rachelhox rachelhox Feb 8, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/forbole/official-website/issues/214#issue-815251146
I added the as attribute in regards to a previous issues with Nextjs routing!
@calvinkei Please see this issue and let me know if you think this is applicable to this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this shouldn't be related. /staking is not a dynamic route and the error returned is not a 404 error. And I cannot reproduce this issue so I have no idea what's the cause

<ListItem
selected={selected}
className={classes.menuItem}
Expand Down
6 changes: 3 additions & 3 deletions locales/en/common.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"unlock password description": "Enter password to unlock your application",
"unlock pasword helper text": "* Require after 15 minutes",
"incorrect password": "Incorrect password",
"security password title": "Wallet Security Password",
"security password title": "Wallet Password",
"security password description": "Create a password to access your wallet",
"import wallet title": "Import Wallet",
"password security level 0": "Weak",
Expand Down Expand Up @@ -76,15 +76,15 @@
"by validators": "by validators",
"accounts": "Accounts",
"change wallet moniker": "Change wallet moniker",
"change security password": "Change wallet security password",
"change security password": "Change wallet password",
"view secret recovery phrase": "View secret recovery phrase",
"add account to wallet": "Add account to wallet",
"delete wallet": "Delete Wallet",
"wallet moniker": "Wallet Moniker",
"current password": "Current Password",
"new password": "New Password",
"save": "Save",
"enter security password": "Please enter wallet security password",
"enter security password": "Please enter wallet password",
"backup password title": "Export Mnemonic",
"export secret recovery phrase title": "Export Secret Recovery Phrase",
"backup password description": "In oder to export your secret recovery phrase properly, we need a password with it will be encrypted for security reasons. Please insert below passwords that you will also be required later when importing it.",
Expand Down
2 changes: 1 addition & 1 deletion locales/zh/common.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"unlock password title": "[zh] Unlock Password",
"unlock password description": "[zh] Enter password to unlock your application",
"incorrect password": "[zh] Incorrect password",
"security password title": "[zh] Wallet Security Password",
"security password title": "[zh] Wallet Password",
"security password description": "[zh] Create a password to access your wallet",
"import wallet title": "[zh] Import Wallet",
"password security level 0": "[zh] Weak",
Expand Down