Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow to handle MsgExec instances properly #75

Merged
merged 4 commits into from
Sep 15, 2022
Merged

feat: allow to handle MsgExec instances properly #75

merged 4 commits into from
Sep 15, 2022

Conversation

RiccardoM
Copy link
Contributor

Description

This PR adds the possibility of handling MsgExec inner messages.

Currently when a MsgExec is executed, the inner messages are not parsed correctly by the various modules. With this PR a new AuthzMessageModule interface is added. Thanks to this, modules will be able to properly handle MsgExec inner messages and parse their data accordingly.

Checklist

  • Targeted PR against correct branch.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit tests.
  • Re-reviewed Files changed in the Github PR explorer.

huichiaotsou
huichiaotsou approved these changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@huichiaotsou huichiaotsou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MonikaCat MonikaCat added the automerge Automatically merge PR once all prerequisites pass label Sep 15, 2022
MonikaCat
MonikaCat approved these changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@MonikaCat MonikaCat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, LGTM

@mergify mergify bot merged commit da81533 into cosmos/v0.44.x Sep 15, 2022
@mergify mergify bot deleted the riccardom/handle-msg-execute branch September 15, 2022 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MonikaCat MonikaCat MonikaCat approved these changes

@huichiaotsou huichiaotsou huichiaotsou approved these changes

Assignees
No one assigned
Labels
automerge Automatically merge PR once all prerequisites pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RiccardoM @MonikaCat @huichiaotsou