Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use sqlx instead of sql #79

Merged
merged 3 commits into from
Sep 20, 2022
Merged

feat: use sqlx instead of sql #79

merged 3 commits into from
Sep 20, 2022

Conversation

RiccardoM
Copy link
Contributor

@RiccardoM RiccardoM commented Sep 20, 2022

Description

This PR updates the PostgreSQL database to use the sqlx driver instead of sql to provide more functionalities while maintaining backward compatibility

Checklist

  • Targeted PR against correct branch.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit tests.
  • Re-reviewed Files changed in the Github PR explorer.

@RiccardoM RiccardoM added the automerge Automatically merge PR once all prerequisites pass label Sep 20, 2022
Copy link
Contributor

@MonikaCat MonikaCat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, LGTM

@mergify mergify bot merged commit 8c0f7f1 into cosmos/v0.44.x Sep 20, 2022
@mergify mergify bot deleted the riccardom/use-sqlx branch September 20, 2022 09:33
mergify bot pushed a commit that referenced this pull request Sep 20, 2022
## Description

This PR updates the linting process to use the `golangci-lint` CLI. This should guarantee major forward compatibility as the golangci-lint version is now tracked within the codebase along with other dependencies

Depends-On: #79 

## Checklist
- [x] Targeted PR against correct branch.
- [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
- [ ] Wrote unit tests.  
- [x] Re-reviewed `Files changed` in the Github PR explorer.
RiccardoM added a commit that referenced this pull request Nov 23, 2022
This PR updates the `PostgreSQL` database to use the sqlx driver instead of `sql` to provide more functionalities while maintaining backward compatibility

- [x] Targeted PR against correct branch.
- [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
- [ ] Wrote unit tests.
- [x] Re-reviewed `Files changed` in the Github PR explorer.
RiccardoM added a commit that referenced this pull request Nov 23, 2022
This PR updates the linting process to use the `golangci-lint` CLI. This should guarantee major forward compatibility as the golangci-lint version is now tracked within the codebase along with other dependencies

Depends-On: #79

- [x] Targeted PR against correct branch.
- [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
- [ ] Wrote unit tests.
- [x] Re-reviewed `Files changed` in the Github PR explorer.
RiccardoM added a commit that referenced this pull request Nov 25, 2022
This PR updates the `PostgreSQL` database to use the sqlx driver instead of `sql` to provide more functionalities while maintaining backward compatibility

- [x] Targeted PR against correct branch.
- [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
- [ ] Wrote unit tests.
- [x] Re-reviewed `Files changed` in the Github PR explorer.
RiccardoM added a commit that referenced this pull request Nov 25, 2022
This PR updates the linting process to use the `golangci-lint` CLI. This should guarantee major forward compatibility as the golangci-lint version is now tracked within the codebase along with other dependencies

Depends-On: #79

- [x] Targeted PR against correct branch.
- [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
- [ ] Wrote unit tests.
- [x] Re-reviewed `Files changed` in the Github PR explorer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge PR once all prerequisites pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants