Bump iOS deployment target to 15.0 #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbirman
commented
Jun 15, 2023
| @@ -3,7 +3,7 @@ require_relative '../node_modules/@react-native-community/cli-platform-ios/nativ | |||
| require_relative '../mobile_sdk/SalesforceMobileSDK-iOS/mobilesdk_pods' | |||
|
|
|||
|
|
|||
| platform :ios, '14.0' | |||
| platform :ios, '15.0' | |||
|
|
|||
| project 'MobileSyncExplorerReactNative.xcodeproj' | |||
There was a problem hiding this comment.
@wmathurin I wasn't sure why this part of the file has 12.0, should I change it to 15 too or leave it?
There was a problem hiding this comment.
That was a fix to make it work with Xcode 14.3 (suggested here). We won't need it once we upgrade to React Native 71.
There was a problem hiding this comment.
Also would you mind fixing that typo since you are in those files :-)
There was a problem hiding this comment.
Oops I copied/pasted the same typo in the other react native templates (e.g. here).
wmathurin
approved these changes
Jun 15, 2023
brandonpage
approved these changes
Jun 15, 2023
wmathurin
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.