CHANGE @W-16891041@ FlowTest rules consolidated #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfeingold35
changed the title
jfeingold35
force-pushed
the
d/W-16891041
branch
from
5a433f7
to
ffa4e75
Compare
jfeingold35
force-pushed
the
d/W-16891041
branch
from
ffa4e75
to
0f46cd4
Compare
jfeingold35
force-pushed
the
d/W-16891041
branch
from
4605333
to
2f07700
Compare
| const consolidatedNames: Set<string> = new Set(getConsolidatedRuleNames()); | ||
| const convertedRules: RuleDescription[] = [...consolidatedNames.values()].map(getConsolidatedRuleByName); |
There was a problem hiding this comment.
Why use a set? Why not just do getConsolidatedRuleNames().map(getConsolidatedRuleByName)?
jfeingold35
force-pushed
the
d/W-16891041
branch
from
b0c4ace
to
2f8cfd4
Compare
Comment on lines
37
to
39
| export function getConsolidatedRuleNames(): string[] { | ||
| return [...QUERY_NAMES_TO_CONSOLIDATED_NAMES.values()]; | ||
| } |
There was a problem hiding this comment.
Oh I see... you use a set in the other spot. I think it should be here to make things unique. So you could here do
[...new Set(QUERY_NAMES_TO_CONSOLIDATED_NAMES.values())]
stephen-carter-at-sf
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.