CHANGE: @W-20035005@: Add latest python code updates to flow engine #382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| expect(countsPerRule).toEqual({ | ||
| MissingDescription: 56, | ||
| MissingFaultHandler: 15, | ||
| MissingFaultHandler: 9, // TODO: Follow up with robert to ensure that this should be 9 (not 15 as it was before) |
Contributor
Author
There was a problem hiding this comment.
WAITING ON THIS TODO
| const results: EngineRunResults = await engine.runRules(PreventPassingUserDataRules, createRunOptions(workspace)); | ||
|
|
||
| expect(results.violations).toHaveLength(1); | ||
| expect(results.violations).toHaveLength(1); // TODO: This test is broken - need to check with Robert about this first! |
Contributor
Author
There was a problem hiding this comment.
WAITING ON THIS TODO
| const results: EngineRunResults = await engine.runRules(PreventPassingUserDataRules, createRunOptions(workspace)); | ||
|
|
||
| expect(results.violations).toHaveLength(1); | ||
| expect(results.violations).toHaveLength(1); // TODO: This test is broken - need to check with Robert about this first! |
Contributor
Author
There was a problem hiding this comment.
WAITING ON THIS TODO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STILL IN DRAFT
NEED TO ASK ROBERT ABOUT BROKEN TESTS