@W-7742718@ Filter PMD results before processing violations #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PMD Java program returns file violations as well as other top level information. We only want to show information about file violations. Filter the results to only include nodes where the name is 'file'. Log all other nodes.
jbartolotta-sfdc
changed the title
jbartolotta-sfdc
commented
Jul 7, 2020
| const fileNodes = pmdJson.elements[0].elements.filter(e => 'file' === e.name); | ||
| const otherNodes = pmdJson.elements[0].elements.filter(e => 'file' !== e.name); | ||
| for (const otherNode of otherNodes) { | ||
| this.logger.trace(`Skipping non-file node ${JSON.stringify(otherNode)}`); |
Contributor
Author
There was a problem hiding this comment.
I added a line item to the 3.0 planning to decide if we want to somehow process these and show them to the user.
rmohan20
approved these changes
Jul 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PMD Java program returns file violations as well as other top level information. We only want to show information about file violations.
Filter the results to only include nodes where the name is 'file'. Log all other nodes.