FIX (CodeAnalyzer) @W-17370746@ - Java Version identification bug fixed #1689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfeingold35
changed the title
stephen-carter-at-sf
approved these changes
Dec 5, 2024
jag-j
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of bug: The bug occurred when
javaHomewas set to a valid path to a real folder, but that folder wasn't a functional Java home (i.e. would throw an error if you used it forblah -version).This happens because an invalid path is caught in an earlier step, and a valid path that corresponds to an unacceptable version of Java is caught in a later step. Both of those cases are properly handled by throwing an SfError. Here, we were just rejecting a Promise, which was bubbling back up through the call stack in an unfriendly way. Properly throwing an SfError resolves the issue.