FIX: @W-16371174@: Fix bug with config commands case insensitivity #1705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| export class AnnotatedConfigModel implements ConfigModel { | ||
| private readonly config: CodeAnalyzerConfig; // TODO: It would be nice if we updated the CodeAnalyzer (in our core module) to just return its CodeAnalyzerConfig with a getter so we didn't need to pass it around |
Contributor
Author
There was a problem hiding this comment.
With the other enhancements that I just pulled in, I was able to accomplish this TODO item as well.
| }); | ||
| } | ||
|
|
||
| // TODO: We should update core module to have this function directly on the Violation object and then remove this helper |
Contributor
Author
There was a problem hiding this comment.
With the other enhancements that I just pulled in, I was able to accomplish this TODO item as well.
| "dependencies": { | ||
| "@oclif/core": "^3.3.2", | ||
| "@salesforce/code-analyzer-core": "0.20.1", | ||
| "@salesforce/code-analyzer-core": "0.20.2", |
Contributor
Author
There was a problem hiding this comment.
This is the main fix
| # label.command-state | ||
|
|
||
| Developer Preview | ||
| Beta |
Contributor
Author
There was a problem hiding this comment.
[FIX-AS-YOU-GO item] We don't want to forget to update this to say "Beta" instead of "Developer Preview" now.
jfeingold35
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.