NEW: @W-17576074@: Create github action to make rollback operation of latest tag easy to do #1715
Conversation
stephen-carter-at-sf
force-pushed
the
sc/W-17576074
branch
2 times, most recently
from
6cf456a to
405c7ae
Compare
| node-version: 'lts/*' | ||
|
|
||
| - name: Fail if one of the permitted users | ||
| if: ${{ github.actor != 'stephen-carter-at-sf' && github.actor != 'jfeingold35' && github.actor != 'jag-j' }} |
There was a problem hiding this comment.
Can we instead check if the actor is part of the https://github.com/orgs/forcedotcom/teams/code-analyzer-core-admin group? Or checking if the actor is a repo admin? Anyway to remove the hardcoded user list here would be better.
There was a problem hiding this comment.
I believe the "Run workflow" button doesn't even appear for folks that aren't repo admins... this was just a further sanity check just in case someone was able to hack in somehow. And I like our names here so that if someone really meant to run this... they would have to contact one of us first.
See some of the github threads about this: https://github.com/orgs/community/discussions/26622
There was a problem hiding this comment.
Then I will favor removing this. But if you think, it should stay, I will leave it up to you.
My concern is that someone other than us three needing to run this sometime in future and needing to change the code to run this.
There was a problem hiding this comment.
OK removed.
… latest tag easy to do (but hopefully we never need to do so)
stephen-carter-at-sf
force-pushed
the
sc/W-17576074
branch
from
405c7ae to
893874a
Compare
… (but hopefully we never need to use this)