CHANGE (CodeAnalyzer): @W-17514797@: v4 release process no longer runs yarn upgrade #1727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephen-carter-at-sf
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The v4 release process previously ran
yarn upgradeand committed the newyarn.lockfile to the release candidate branch.This was determined to cause problems when, for example, a new version of an engine adds a new rule, thereby changing the rule count and breaking unit tests.
To avoid this in the future, we are ending the practice of auto-upgrading dependencies in the release branch. Instead, this will be done manually (possibly with the aid of a new GHA to create a PR automatically, though this GHA has yet to be written) midway through the release cycle.