Skip to content

CHANGE: @W-17530186@: Update dependencies where possible except for o… #1729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephen-carter-at-sf merged 1 commit into from
Jan 23, 2025
Merged

CHANGE: @W-17530186@: Update dependencies where possible except for o… #1729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,10 @@
"project": "./tsconfig.json"
},
"rules": {
"@typescript-eslint/no-unused-vars": ["error", {"argsIgnorePattern": "^_"}],
"@typescript-eslint/no-unused-vars": ["error", {
"argsIgnorePattern": "^_",
"varsIgnorePattern": "^_",
"caughtErrorsIgnorePattern": "^_"}],
"@typescript-eslint/unbound-method": ["error", {"ignoreStatic": true}]
},
"plugins": [
Expand Down
44 changes: 22 additions & 22 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,40 +6,40 @@
"bugs": "https://github.com/forcedotcom/sfdx-scanner/issues",
"dependencies": {
"@oclif/core": "^3.3.2",
Copy link
Contributor Author

@stephen-carter-at-sf stephen-carter-at-sf Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could not update this without breaking changes... so we'll want to do this separately in its own work item.

"@salesforce/code-analyzer-core": "0.21.0",
"@salesforce/code-analyzer-engine-api": "0.16.1",
"@salesforce/code-analyzer-eslint-engine": "0.18.0",
"@salesforce/code-analyzer-flowtest-engine": "0.16.3",
"@salesforce/code-analyzer-pmd-engine": "0.18.0",
"@salesforce/code-analyzer-regex-engine": "0.16.2",
"@salesforce/code-analyzer-retirejs-engine": "0.16.2",
"@salesforce/code-analyzer-core": "0.22.0",
"@salesforce/code-analyzer-engine-api": "0.17.0",
"@salesforce/code-analyzer-eslint-engine": "0.19.0",
"@salesforce/code-analyzer-flowtest-engine": "0.17.0",
"@salesforce/code-analyzer-pmd-engine": "0.19.0",
"@salesforce/code-analyzer-regex-engine": "0.17.0",
"@salesforce/code-analyzer-retirejs-engine": "0.17.0",
"@salesforce/core": "^5",
Copy link
Contributor Author

@stephen-carter-at-sf stephen-carter-at-sf Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could not update this without breaking changes... so we'll want to do this separately in its own work item.

"@salesforce/sf-plugins-core": "^5.0.4",
Copy link
Contributor Author

@stephen-carter-at-sf stephen-carter-at-sf Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could not update this without breaking changes... so we'll want to do this separately in its own work item.

"@salesforce/ts-types": "^2.0.9",
"@salesforce/ts-types": "^2.0.12",
"@types/js-yaml": "^4.0.9",
"@types/node": "^22.5.5",
"ansis": "^3.2.0",
"fast-glob": "^3.3.2",
"@types/node": "^22.10.9",
"ansis": "^3.9.0",
"fast-glob": "^3.3.3",
"js-yaml": "^4.1.0",
"ts-node": "^10",
"tslib": "^2"
},
"devDependencies": {
"@eslint/js": "^8.57",
"@oclif/plugin-help": "^5",
"@salesforce/cli-plugins-testkit": "^5.3.8",
"@types/jest": "^29.5.12",
"@eslint/js": "^8.57.1",
"@oclif/plugin-help": "^6.2.22",
"@salesforce/cli-plugins-testkit": "^5.3.39",
"@types/jest": "^29.5.14",
"@types/tmp": "^0.2.6",
"@typescript-eslint/eslint-plugin": "^7.2.0",
"@typescript-eslint/parser": "^7.2.0",
"eslint": "^8.57",
"eslint-plugin-sf-plugin": "^1.17.4",
"@typescript-eslint/eslint-plugin": "^8.21.0",
"@typescript-eslint/parser": "^8.21.0",
"eslint": "^8.57.1",
Copy link
Contributor Author

@stephen-carter-at-sf stephen-carter-at-sf Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sticking with v8 for now... to migrate to v9 we'll have to switch our .eslintrc.json and .eslintignore files over to the new flat config world - which we should do in its own work item at some point.

"eslint-plugin-sf-plugin": "^1.20.14",
"jest": "^29.7.0",
"jest-junit": "^16.0.0",
"oclif": "^4.0.3",
"oclif": "^4.17.17",
"tmp": "^0.2.3",
"ts-jest": "^29.1.4",
"typescript": "^5.4.5"
"ts-jest": "^29.2.5",
"typescript": "^5.7.3"
},
"engines": {
"node": ">=20.0.0"
Expand Down
2 changes: 1 addition & 1 deletion src/lib/models/ConfigModel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ abstract class YamlFormatter {
private getDefaultRuleFor(engineName: string, ruleName: string): Rule|null {
try {
return this.allDefaultRules.getRule(engineName, ruleName);
} catch (e) {
} catch (_e) {
// istanbul ignore next
return null;
}
Expand Down
2 changes: 1 addition & 1 deletion src/lib/utils/FileUtil.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ export async function exists(filename: string): Promise<boolean> {
try {
await fs.promises.access(filename, fs.constants.F_OK);
return true;
} catch (e) {
} catch (_e) {
return false;
}
}
Loading
Loading