CHANGE: @W-17662327@: Update dependencies as much as possible #1738
Conversation
| } | ||
| } | ||
| ), | ||
| ...fixupConfigRules(compat.extends("plugin:sf-plugin/recommended")), |
There was a problem hiding this comment.
This is essentially how we keep using the sf-plugin rules even though they haven't migrated to support flat config yet.
| "@eslint/compat": "^1.2.5", | ||
| "@eslint/eslintrc": "^3.2.0", |
There was a problem hiding this comment.
These are needed to maintain the use of the sf-plugin rules which do not support flat config yet... so we need compatibility wrappers.
| "@salesforce/core": "^5", | ||
| "@salesforce/sf-plugins-core": "^5.0.4", | ||
| "@salesforce/core": "6.7.6", | ||
| "@salesforce/sf-plugins-core": "5.0.13", |
There was a problem hiding this comment.
Note that since we will be updating these modules regularly now… since JSON doesn’t allow you to add comments, I am basically just removing the ^ prefix for any version that we shouldn’t be updating for whatever reason. This will help us know that there is some issue that we need to look into before attempting to update again. I'll keep notes on the work items... so we can always just look back at them.
Note that we cannot go past:
Mainly because @salesforce/sf-plugins-core v6 is an ESM module and given the nature of how the flags are setup with SfCommand as static property... we can't dynamically import Flags from our commonJS module without a dynamic import - which is not possible at the top level needed for static property.
And because we are stuck on v5 here, this forces us to be stuck on oclif v3 and core v6 due to conflicts if you attempt to upgrade those without also upgrading sf-plugins-core.
Otherwise, I updated everything else, including eslint to v9 (which means we had to move to flat config with compatibility).