CHANGE: @W-18097146@ Updates for GA #1771

randi274 · 2025-03-31T20:46:10Z

Remove the word "Beta" and any language around going GA. Update Github actions to be as ready for v5 as we can while we still need to support v4.

randi274 · 2025-03-31T20:47:10Z

.github/workflows/automated-release-tasks.yml

+              ref: 'dev',
+              inputs: {
+                "release-type": "patch"
+              }


When running this locally, using "patch" as the version helped update the package.json version correctly for me:

Hey this is great news! We'll do this instead of manually creating it then for this month. Great find.

Yeah, for this month we want to run it as patch. Good call.

randi274 · 2025-03-31T20:47:43Z

.github/workflows/create-release-branch.yml

 name: create-release-branch
 on:
  workflow_dispatch:
+    inputs:


However, I also thought it prudent to add in the manual option back in case we need to re-run (for whatever reason)

Yeah, we definitely need this now.

randi274 · 2025-03-31T20:48:09Z

.github/workflows/create-release-branch.yml

      - name: Locally increment version
        run: |
-          npm --no-git-tag-version version prerelease --preid beta
+          # A workflow dispatch event lets the user specify what release type they want.


I found this on dev-4 👀

Yeah, this makes it so the automated monthly execution defaults to minor. It won't cause a problem here because patch is being explicitly passed in, and it's technically also unnecessary in v4 because minor gets explicitly passed in there too.
But it's still a nice thing to have.

randi274 · 2025-03-31T20:48:59Z

.github/workflows/run-tests.yml

        run: |
          # We need to determine the Tarball's name first.
-          TARBALL_NAME=$(ls ~/downloads/tarball | grep salesforce-plugin-code-analyzer-5\\.0\\.0-beta\\.[0-9]*\\.tgz)
+          TARBALL_NAME=$(ls ~/downloads/tarball | grep salesforce-plugin-code-analyzer-*.*.tgz)


Regex is not my favorite, but I think this will work. Let me know if there's a better approach here!

means 0 or more... and it refers to the character it precedes.
So when you do -* that means zero or more - characters. This isn't what you want.

. means any character. So .* means zero or more of any character.

\. means the literal . but we need to have \. so we actually provide to grep \. because \ is the escape character and thus \ is interpreted as ''.

So what you really want here is:

TARBALL_NAME=$(ls ~/downloads/tarball | grep salesforce-plugin-code-analyzer-.*\\.tgz)

alternatively if we want to be more strict and require 5.x.y we would have:

TARBALL_NAME=$(ls ~/downloads/tarball | grep salesforce-plugin-code-analyzer-5\\.[0-9]*\\.[0-9]*\\.tgz)

does that make sense?

that does, thank you! I like the looser version here since we're using it in a build option, and it would be nice not to have to update this when the major version changes again (since this was not an intuitive find for me either)

stephen-carter-at-sf · 2025-04-01T12:00:10Z

.git2gus/config.json

 {
    "productTag": "a1aB0000000c7jnIAA",
-    "defaultBuild": "[SFCA] Scanner 4.0",
+    "defaultBuild": "[SFCA] Code Analyzer 5.0.0",


I put a message in slack about this. We need whatever build we put here to first live in GUS.

stephen-carter-at-sf · 2025-04-01T12:08:31Z

.github/workflows/automated-release-tasks.yml

+              ref: 'dev',
+              inputs: {
+                "release-type": "patch"
+              }


Hey this is great news! We'll do this instead of manually creating it then for this month. Great find.

stephen-carter-at-sf · 2025-04-01T12:12:12Z

.github/workflows/daily-smoke-tests.yml

+            await github.rest.actions.createWorkflowDispatch({
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              workflow_id: 'daily-smoke-tests.yml',


I'm a little confused. Isn't this an infinite loop? Isn't line 11 already running the smoke test? This new section will call this same file again wouldn't it?

Great point, I think this needs a re-write. Let me take another stab at that 😄

stephen-carter-at-sf · 2025-04-01T12:17:55Z

.github/workflows/run-tests.yml

        run: |
          # We need to determine the Tarball's name first.
-          TARBALL_NAME=$(ls ~/downloads/tarball | grep salesforce-plugin-code-analyzer-5\\.0\\.0-beta\\.[0-9]*\\.tgz)
+          TARBALL_NAME=$(ls ~/downloads/tarball | grep salesforce-plugin-code-analyzer-*.*.tgz)


means 0 or more... and it refers to the character it precedes.
So when you do -* that means zero or more - characters. This isn't what you want.

. means any character. So .* means zero or more of any character.

\. means the literal . but we need to have \. so we actually provide to grep \. because \ is the escape character and thus \ is interpreted as ''.

So what you really want here is:

TARBALL_NAME=$(ls ~/downloads/tarball | grep salesforce-plugin-code-analyzer-.*\\.tgz)

alternatively if we want to be more strict and require 5.x.y we would have:

TARBALL_NAME=$(ls ~/downloads/tarball | grep salesforce-plugin-code-analyzer-5\\.[0-9]*\\.[0-9]*\\.tgz)

does that make sense?

randi274 · 2025-04-01T14:02:59Z

.github/workflows/daily-smoke-tests-v4.yml

@@ -0,0 +1,29 @@
+#TODO: remove v4 with April Release


@stephen-carter-at-sf I opted to keep this separate for easy deletion. I'm not quite sure why we need the script to invoke the tests, but I updated daily-smoke-tests to just work off of dev.

What exactly were you confused about? I'm not quite sure I understand.

cron based jobs can only run from dev. So from dev we dispatch the actual v4 script from the dev-4 branch. What you have here is correct.

jfeingold35 · 2025-04-01T14:12:41Z

.github/ISSUE_TEMPLATE/0-code_analyzer_bug.yml

Question: Do we want to have separate issues for the run, rules, and config commands like we do for the v4 commands?

I don't think we should. Besides that is a separate discussion outside the scope of this PR.

I was wondering the same thing @jfeingold35 - we could add that as we get additional feedback indicating we need more info per command, but I do like the option to make it simpler too (that's my plan for the follow-up WI 18163361)

jfeingold35 · 2025-04-01T14:14:01Z

.github/workflows/automated-release-tasks.yml

+              ref: 'dev',
+              inputs: {
+                "release-type": "patch"
+              }


Yeah, for this month we want to run it as patch. Good call.

jfeingold35 · 2025-04-01T14:15:19Z

.github/workflows/create-release-branch.yml

 name: create-release-branch
 on:
  workflow_dispatch:
+    inputs:


Yeah, we definitely need this now.

jfeingold35 · 2025-04-01T14:18:33Z

.github/workflows/create-release-branch.yml

      - name: Locally increment version
        run: |
-          npm --no-git-tag-version version prerelease --preid beta
+          # A workflow dispatch event lets the user specify what release type they want.


Yeah, this makes it so the automated monthly execution defaults to minor. It won't cause a problem here because patch is being explicitly passed in, and it's technically also unnecessary in v4 because minor gets explicitly passed in there too.
But it's still a nice thing to have.

jfeingold35 · 2025-04-01T14:20:15Z

.github/workflows/validate-pr.yml

 jobs:
  # We want to prevent cross-contamination between the 4.x and 5.x pipelines. So we should prevent PRs
  # based on this flow to merge into `dev-4` or `main-4`.
+  # TODO: Remove this after the April release, since we won't care after that to maintain v4


Note: You'll also need to remove this job as a Required job for the branch protection rule.

jfeingold35 · 2025-04-01T14:23:22Z

.github/workflows/run-tests.yml

          path: ~/downloads/tarball
      - name: Echo tarball download location
        run: echo ${{ steps.download.outputs.download-path }}
+        # TODO: update ASAP after April Release


What's the update that needs to happen here?

oh good call - this isn't necessary with the latest change. I'll remove!

jfeingold35 · 2025-04-01T14:23:33Z

.github/workflows/run-tests.yml

        run: |
          # We need to determine the Tarball's name first.
-          TARBALL_NAME=$(ls ~/downloads/tarball | grep salesforce-plugin-code-analyzer-5\\.0\\.0-beta\\.[0-9]*\\.tgz)
+          TARBALL_NAME=$(ls ~/downloads/tarball | grep salesforce-plugin-code-analyzer-.*\\.tgz)


I recommend greping for salesforce-plugin-code-analyzer-5\\.[0-9]*\\.[0-9]*\\.tgz.

This one I realized we'll need to wait until after we go GA, but we can clean that up then if you'd like 👍

jfeingold35 · 2025-04-01T14:27:27Z

.github/workflows/daily-smoke-tests.yml

-              workflow_id: 'daily-smoke-tests.yml',
-              ref: 'dev-4'
-            });
+      branch: dev


Request: Could you add a comment covering the explanation I gave the other day? i.e.,

We run the daily smoke tests against 'dev' to validate that the code currently in development is still valid

or something like that?

Good point to clarify!

jfeingold35 · 2025-04-01T14:27:49Z

.github/workflows/daily-smoke-tests-v4.yml

@@ -0,0 +1,29 @@
+#TODO: remove v4 with April Release


What exactly were you confused about? I'm not quite sure I understand.

CHANGE: @W-18097146@ Updates for GA

94d19db

randi274 commented Mar 31, 2025

View reviewed changes

stephen-carter-at-sf requested changes Apr 1, 2025

View reviewed changes

Review updates

eaac0f5

randi274 commented Apr 1, 2025

View reviewed changes

stephen-carter-at-sf approved these changes Apr 1, 2025

View reviewed changes

jfeingold35 reviewed Apr 1, 2025

View reviewed changes

randi274 added 2 commits April 1, 2025 11:32

last round of review

294c6c8

regex cleanup for today

fc4337c

randi274 merged commit c1f36b8 into dev Apr 1, 2025
12 checks passed

randi274 deleted the randi/W-18097146 branch April 1, 2025 16:05

CHANGE: @W-18097146@ Updates for GA #1771

CHANGE: @W-18097146@ Updates for GA #1771

Uh oh!

Conversation

randi274 commented Mar 31, 2025

Uh oh!

randi274 Mar 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

randi274 Apr 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

randi274 Mar 31, 2025 •

edited

Loading

randi274 Apr 1, 2025 •

edited

Loading