NEW: @W-18173799@: Update config command to not quit if engine valida… #1773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| spyDisplay = new SpyDisplay(); | ||
| dependencies = { | ||
| logEventListeners: [], | ||
| logEventListeners: [new LogEventDisplayer(spyDisplay)], |
Contributor
Author
There was a problem hiding this comment.
Took me forever to understand why this test wasn't producing the error messages in the display. Then I realized we do not have the log event listeners or progress listeners added. I only added in the log event listeners here - wasn't sure if the progress listeners would cause other tests to fail or not.
Comment on lines
+538
to
+544
| if (displayEvents[4].type === DisplayEventType.LOG) { | ||
| return ansis.strip(displayEvents[4].data); | ||
| } else if (displayEvents[5].type === DisplayEventType.LOG) { | ||
| return ansis.strip(displayEvents[5].data); | ||
| } else { | ||
| return 'Could Not Get Specific Output'; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
I'm not a fan of how this test file assumes [4] is the output. It makes the test fragile. At some point we should improve this - but for now I'm just adding in some conditional code to account for the fact that there might be an error display event before the output display event.
jfeingold35
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tion fails