NEW @W-17015980@ Integrated --target functionality #1775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfeingold35
commented
Apr 10, 2025
stephen-carter-at-sf
requested changes
Apr 11, 2025
stephen-carter-at-sf
changed the title
jfeingold35
commented
Apr 15, 2025
| <%= config.bin %> <%= command.id %> --rule-selector Recommended | ||
|
|
||
| - Display the configuration state associated with all the rules that are applicable to your workspace folder, `./src`: | ||
| - Display the configuration state associated with all the rules that are applicable to the files targeted within the folder `./src`: |
Contributor
Author
There was a problem hiding this comment.
I feel like we should have separate examples for --target and --workspace to demonstrate how they interplay?
jfeingold35
commented
Apr 15, 2025
messages/config-command.md
Outdated
| Use the `--workspace` flag to display only the configuration associated with the rules that apply to the files that make up your workspace. Typically, a workspace is a single project folder that contains all your files. But it can also consist of one or more folders, one or more files, and use glob patterns (wildcards). If you specify this flag multiple times, then your workspace is the sum of the files and folders. | ||
|
|
||
| This command uses the type of file in the workspace, such as JavaScript or Typescript, to determine the rules to include in the configuration state. For example, if your workspace contains only JavaScript files, the command doesn't include TypeScript rules. The command uses a file's extension to determine what kind of file it is, such as ".ts" for TypeScript. | ||
| This command uses the type of file in the workspace, such as JavaScript or Typescript, to determine which configuration state is applicable. For example, if your workspace contains only JavaScript files, then the command doesn't display configuration state associated with TypeScript rules. The command uses a file's extension to determine what kind of file it is, such as ".ts" for TypeScript. |
Contributor
Author
There was a problem hiding this comment.
This should probably be types of file, right?
jfeingold35
force-pushed
the
d/W-17915980
branch
from
8162ac4 to
c28033c
Compare
messages/config-command.md
Outdated
| Use the `--workspace` flag to display only the configuration associated with the rules that apply to the files that make up your workspace. Typically, a workspace is a single project folder that contains all your files. But it can also consist of one or more folders, one or more files, and use glob patterns (wildcards). If you specify this flag multiple times, then your workspace is the sum of the files and folders. | ||
|
|
||
| This command uses the type of file in the workspace, such as JavaScript or Typescript, to determine the rules to include in the configuration state. For example, if your workspace contains only JavaScript files, the command doesn't include TypeScript rules. The command uses a file's extension to determine what kind of file it is, such as ".ts" for TypeScript. | ||
| This command uses the types of file in the workspace, such as JavaScript or Typescript, to determine which configuration state is applicable. For example, if your workspace contains only JavaScript files, then the command doesn't display configuration state associated with TypeScript rules. The command uses a file's extension to determine what kind of file it is, such as ".ts" for TypeScript. |
Contributor
There was a problem hiding this comment.
Small little thing: Looks like there is 2 spaces between the words: files, then
Contributor
Author
There was a problem hiding this comment.
Fixed. Also removed some other double-spaces.
stephen-carter-at-sf
approved these changes
Apr 15, 2025
jshackell-sfdc
requested changes
Apr 15, 2025
Contributor
jshackell-sfdc
left a comment
jshackell-sfdc
left a comment
There was a problem hiding this comment.
@jfeingold35 , here's my edit. I did my best to catch everything, but let me know if I got something wrong.
| To apply a custom configuration with Code Analyzer, either keep your custom configuration settings in a `code-analyzer.yml` file located in the current folder from which you are executing commands, or specify the location of your custom configuration file to the Code Analyzer commands with the --config-file flag. | ||
|
|
||
| We're continually improving Salesforce Code Analyzer. Tell us what you think! Give feedback at http://sfdc.co/CodeAnalyzerFeedback. | ||
| We're continually improving Salesforce Code Analyzer. Tell us what you think! Give feedback at https://sfdc.co/CodeAnalyzerFeedback. |
Contributor
There was a problem hiding this comment.
Yikes! Thanks for catching that...
Co-authored-by: Juliet Shackell <63259011+jshackell-sfdc@users.noreply.github.com>
Co-authored-by: Juliet Shackell <63259011+jshackell-sfdc@users.noreply.github.com>
jshackell-sfdc
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
--path-startflag onrun.tswith--target--targettorulesandconfig