CHANGE: @W-18394257@ Update DevOps Post-GA #1787

randi274 · 2025-04-30T18:15:02Z

Notes:

All "TODO"s from April GA release are removed
There is no production heartbeat action run off of dev-4.
There is no daily-smoke-test run off dev-4.
We will no longer create a release branch with dev-4 for v4.
There is no additional branch protection on dev-4 or main-4 in the validate-pr action
Remove Issue Templates for SFDX Scanner features

stephen-carter-at-sf · 2025-05-01T12:48:27Z

.github/ISSUE_TEMPLATE/1-feature_request.yml

Note that the 1 through 5 doesn't show up to the user on the https://github.com/forcedotcom/sfdx-scanner/issues/new/choose page - they are just there to dictate ordering. But with that said - they do show up in the urls. Note that our documentation page over at https://developer.salesforce.com/docs/platform/salesforce-code-analyzer/guide/get-started.html#5-report-bugs-feedback-and-request-new-features links to https://github.com/forcedotcom/sfdx-scanner/issues/new?template=5-feature_request.yml explicitly. So if we wanted to move this, we'd need to first have the doc updated.
For now, just delete - but please don't rename anything.

Thank you for recalling that! I will update.

jfeingold35 · 2025-05-02T14:47:30Z

.github/ISSUE_TEMPLATE/6-general_feedback.yml

Is there a reason not to name this 1-general_feedback.yml?

I know, 6 felt so weird! Do you think it works for that order? I kind of wanted general feedback to be last, but I don't have a strong preference.

"General feedback" being last makes total sense, but if we're deleting 1-5, then we can just promote this to 1, right?

Unfortunately we have to keep 5 as it is since we have a hard-coded link in our docs to it, so we can be 0,1,5 or 0,5,6 (for today, at least!)

Fair enough.

jfeingold35 · 2025-05-02T14:52:49Z

.github/workflows/automated-release-tasks.yml

+        secrets: inherit
        with:
-          github-token: ${{ secrets.SVC_CLI_BOT_GITHUB_TOKEN }}
-          # TODO: remove inputs after April Release; will default to minor


I read this comment as referring to the inputs property on the script object. If you remove that property, then the default value for release-type will just be minor, which is what we want.
Are you sure we're able to remove this workflow dispatch and just directly call the workflow as a step?

Let me make a fork to double check this one 👍

Good callout on this - I did need to make changes over with the fork to make this work! Here's a run that calls create-release-branch successfully: https://github.com/randi274/sfdx-scanner/actions/runs/14800941925

It doesn't look like that commit has any changes. Is that expected?

It was a lot of small commits over there, but this is the one that should work here: 91dd103

And then the code over there should be correct on dev now

jfeingold35 · 2025-05-02T14:55:55Z

.github/workflows/production-heartbeat.yml

-              workflow_id: 'production-heartbeat.yml',
-              ref: 'dev-4'
-            });
+  smoke-test:


This looks incorrect to me. I'm not seeing where the logic that would call out to PagerDuty is?

Ah, good point! I don't think I connected that the purpose of that was to callout to PagerDuty. Is that what the createWorkflowDispatch is doing here?

@jfeingold35 here's the successful run to the heartbeat! Thanks for walking through that together. There might be some additional improvements to be made here too (possible follow-up WI).

https://github.com/randi274/sfdx-scanner/actions/runs/14801505744/job/41561089789

I did notice in the output of the job that we don't have python installed either so I made a follow-up WI for that: https://github.com/randi274/sfdx-scanner/actions/runs/14801505744/artifacts/3052802686

.github/workflows/validate-pr.yml

.github/workflows/production-heartbeat.yml

.github/workflows/heartbeat-tests.yml

randi274 · 2025-05-19T16:32:24Z

.github/ISSUE_TEMPLATE/1-scanner_run_bug.yml

Note: Add a new issue config to remove the blank issue that appears. https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository

Should not use critical severity

randi274 · 2025-05-19T18:12:25Z

.github/ISSUE_TEMPLATE/0-code_analyzer_bug.yml

 labels: []
 body:
-  - type: dropdown
+  - type: checkboxes


@stephen-carter-at-sf I was able to get validation to work on checkboxes, and thought it looked a little cleaner:

randi274 · 2025-05-19T18:13:23Z

.github/ISSUE_TEMPLATE/1-scanner_bug.yml

@@ -0,0 +1,123 @@
+name: Report a Bug with a scanner command (v4)


I was thinking this could be the new catch-all for scanner bugs

randi274 · 2025-05-19T18:14:21Z

.github/ISSUE_TEMPLATE/config.yml

@@ -0,0 +1 @@
+blank_issues_enabled: false


This will prevent the blank issues option from appearing.

Additionally, if we want other repos to point elsewhere for issue tracking, we could do that using this config file. https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository

randi274 · 2025-05-19T18:15:30Z

.github/workflows/heartbeat-tests.yml

@@ -0,0 +1,147 @@
+name: heartbeat-tests


@stephen-carter-at-sf I removed production-heartbeat, and now this is the singular heartbeat tests workflow. Does the name work for you, or any changes requested?

I"m fine with name.

randi274 · 2025-05-19T18:15:52Z

.github/workflows/heartbeat-tests.yml

+          java-version: '11'
+      - uses: actions/setup-python@v5
+        with:
+        python-version: '3.10'


I set the python version to match what our docs require.

randi274 · 2025-05-19T18:16:17Z

.github/workflows/heartbeat-tests.yml

+          RUN_LINK: https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}
+        run: |
+          # GHA env-vars don't have robust conditional logic, so we'll use this if-else branch to define some bash env-vars.
+          ALERT_SEV="info"


Here is the change to update our Alert Severity to "info".

stephen-carter-at-sf · 2025-05-19T18:31:58Z

.github/ISSUE_TEMPLATE/0-code_analyzer_bug.yml

 labels: []
 body:
-  - type: dropdown
+  - type: checkboxes


stephen-carter-at-sf · 2025-05-19T18:32:25Z

.github/ISSUE_TEMPLATE/1-scanner_bug.yml

@@ -0,0 +1,123 @@
+name: Report a Bug with a scanner command (v4)


stephen-carter-at-sf · 2025-05-19T18:32:48Z

.github/ISSUE_TEMPLATE/1-scanner_bug.yml

+    attributes:
+      label: Python Version
+      description: |
+        What do you get from the command "python --version"?
+      placeholder: |
+        Example: Python 3.11.8


We don't need python for scanner command... so we don't need this

stephen-carter-at-sf · 2025-05-19T18:35:53Z

.github/workflows/heartbeat-tests.yml

@@ -0,0 +1,147 @@
+name: heartbeat-tests


I"m fine with name.

stephen-carter-at-sf requested changes May 1, 2025

View reviewed changes

jfeingold35 reviewed May 2, 2025

View reviewed changes

randi274 commented May 19, 2025

View reviewed changes

.github/workflows/production-heartbeat.yml Outdated Show resolved Hide resolved

randi274 commented May 19, 2025

View reviewed changes

.github/workflows/heartbeat-tests.yml Outdated Show resolved Hide resolved

randi274 commented May 19, 2025

View reviewed changes

randi274 added 7 commits May 19, 2025 13:51

CHANGE: @W-18394257@ Update DevOps Post-GA

bc1d122

Rename issue templates

170ffbf

Update release branch actions

7da703f

Put back validate pr step

722b6a9

Add heartbeat

2899259

Update .github/workflows/heartbeat-tests.yml

5e2a509

Should not use critical severity

Requirements feedback

7e75a56

randi274 force-pushed the randi/W-18394257-dev-ops-GA-updates branch from 0cc89aa to 7e75a56 Compare May 19, 2025 17:52

randi274 added 2 commits May 19, 2025 14:07

Update to checkboxes

f6a7f2b

Validations cleanup

d50a8a4

randi274 commented May 19, 2025

View reviewed changes

stephen-carter-at-sf reviewed May 19, 2025

View reviewed changes

Remove python from scanner issue

a3fd3d4

stephen-carter-at-sf approved these changes May 19, 2025

View reviewed changes

randi274 merged commit 74ff189 into dev May 19, 2025
10 checks passed

randi274 deleted the randi/W-18394257-dev-ops-GA-updates branch May 19, 2025 19:20

randi274 mentioned this pull request Aug 5, 2025

CHANGE: @W-18163361@ Clean up lingering v4 build changes #1869

Merged

		@@ -0,0 +1,123 @@
		name: Report a Bug with a scanner command (v4)

		@@ -0,0 +1 @@
		blank_issues_enabled: false No newline at end of file

CHANGE: @W-18394257@ Update DevOps Post-GA #1787

CHANGE: @W-18394257@ Update DevOps Post-GA #1787

Uh oh!

Conversation

randi274 commented Apr 30, 2025

Uh oh!

stephen-carter-at-sf May 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

stephen-carter-at-sf May 1, 2025 •

edited

Loading