NEW(config): @W-18541853@: Stop displaying unmodified rules and add in --include-unmodified-rules flag #1812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
fixes: #1795 |
stephen-carter-at-sf
force-pushed
the
sc/W-18541853
branch
from
e842d86 to
db4f69a
Compare
| # command.summary | ||
|
|
||
| Display the current state of configuration for Code Analyzer. | ||
| Output the current state of configuration for Code Analyzer. |
Contributor
Author
There was a problem hiding this comment.
Since the command is for either displaying to the terminal or writing to a file. I think the world "Output" makes more sense here.
|
|
||
| // ==== ASSERTIONS ==== | ||
| expect(output).toContain('rules: {} # Remove this empty object {} when you are ready to specify your first rule override'); | ||
| expect(output).toContain('rules: {} # Empty object used because rule selection returned no rules'); |
Contributor
Author
There was a problem hiding this comment.
Fixed this case to be more explicit as to what happened.
…n --include-unmodified-rules flag
stephen-carter-at-sf
force-pushed
the
sc/W-18541853
branch
from
db4f69a to
5291697
Compare
randi274
approved these changes
May 20, 2025
Contributor
randi274
left a comment
randi274
left a comment
There was a problem hiding this comment.
Looks good! Some of the constructors are starting to get a little long with their parameter lists, but I don't know that that immediately needs refactoring.
Contributor
Author
|
I agree. We should refactor the config command soon. I created W-18573046. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.