Skip to content

CHANGE: @W-18163361@ Clean up lingering v4 build changes #1869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
randi274 merged 2 commits into from
Aug 6, 2025
Merged

CHANGE: @W-18163361@ Clean up lingering v4 build changes #1869

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18e18cb
CHANGE: @W-18163361@ Clean up lingering v4 build changes
randi274 Aug 5, 2025
b1dfa55
Enhance log output rendering
randi274 Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .git2gus/config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"productTag": "a1aB0000000c7jnIAA",
"defaultBuild": "[SFCA] Scanner 4.0",
"defaultBuild": "[SFCA] Code Analyzer 5.x",
"hideWorkItemUrl": "true",
"issueTypeLabels": {
"type:feature": "USER STORY",
Expand All @@ -21,4 +21,4 @@
},
"gusTitlePrefix": "[GitHub Issue]",
"statusWhenClosed": "FIXED"
}
}
3 changes: 2 additions & 1 deletion .github/ISSUE_TEMPLATE/0-code_analyzer_bug.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ body:
label: Output / Logs
description: Attach any output or logs here.
placeholder: |
Add log output or drag files here.
Add log output here. This will be automatically formatted into code, so no need for backticks.
render: shell
- type: textarea
attributes:
label: Steps To Reproduce
Expand Down
113 changes: 0 additions & 113 deletions .github/ISSUE_TEMPLATE/1-scanner_bug.yml
View file
Open in desktop

This file was deleted.

25 changes: 12 additions & 13 deletions .github/ISSUE_TEMPLATE/2-vscode_extension_bug.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ body:
label: Output / Logs
description: Attach any output or logs here.
placeholder: |
Add log output or drag files here.
Add log output here. This will be automatically formatted into code, so no need for backticks.
render: shell
- type: textarea
attributes:
label: Steps To Reproduce
Expand Down Expand Up @@ -65,22 +66,20 @@ body:
required: true
- type: input
attributes:
label: Salesforce CLI Version
label: Extension Version
Copy link
Contributor Author

@randi274 randi274 Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recalled during cleanup that this was still missing, and thought now was a great time to add this in too

description: |
What do you get when you run the "sf --version" command in the terminal?
What version do you see for the Salesforce Code Analyzer VS Code Extension?
placeholder: |
Example: @salesforce/cli/2.90.4 darwin-x64 node-v22.15.0
Example: Version: 1.9.0
validations:
required: true
- type: dropdown
- type: input
attributes:
label: Using v4
description: "Are you using Code Analyzer v4? (Is the setting 'Code Analyzer: Use v4 (Deprecated)' checked?)"
options:
- ""
- "No"
- "Yes"
- "Not sure"
label: Salesforce CLI Version
description: |
What do you get when you run the "sf --version" command in the terminal?
placeholder: |
Example: @salesforce/cli/2.90.4 darwin-x64 node-v22.15.0
validations:
required: true
- type: input
Expand All @@ -89,7 +88,7 @@ body:
description: |
What do you get when you run the "sf plugins" command in the terminal?
placeholder: |
code-analyzer 5.0.0; or if using v4: @salesforce/sfdx-scanner 4.12.0
code-analyzer 5.0.0
validations:
required: false
- type: input
Expand Down
8 changes: 0 additions & 8 deletions .github/workflows/validate-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,6 @@ on:
types: [edited, opened, reopened, synchronize]

jobs:
# Prevent merging to dev-4 or main-4 to preserve until we're ready to delete
verify_target_branch:
runs-on: ubuntu-latest
steps:
- if: ${{ github.base_ref == 'dev-4' || github.base_ref == 'main-4' }}
run: |
echo "Forbidden to merge this branch into dev-4 or main-4"
exit 1
# We need to verify that the Pull Request's title matches the desired format.
verify_pr_title:
runs-on: ubuntu-latest
Expand Down
Loading