Skip to content

CHANGE: @W-20005455@: Remove table borders #1920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephen-carter-at-sf merged 1 commit into from
Oct 24, 2025
Merged

CHANGE: @W-20005455@: Remove table borders #1920

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/lib/Display.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,17 @@ export class UxDisplay implements Display {
}

public displayTable<R extends Record<string, unknown>>(options: TableOptions<R>): void {
this.displayable.table(options);
// Unfortunately the table options borderStyle and noStyle don't do anything because
// I believe sfCommand always overrides them or something. But the environment variable
// SF_TABLE_BORDER_STYLE still seems to work so we'll use this to prevent adding border lines
// which make large overflowing tables look ugly. This seems to look good:
const original_SF_TABLE_BORDER_STYLE = process.env.SF_TABLE_BORDER_STYLE;
process.env.SF_TABLE_BORDER_STYLE = 'headers-only-with-underline';
try {
this.displayable.table(options);
} finally {
process.env.SF_TABLE_BORDER_STYLE = original_SF_TABLE_BORDER_STYLE;
}
}

public confirm(message: string): Promise<boolean> {
Expand Down