Skip to content

Only build dependencies once on deploy command #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markdlv-sf merged 1 commit into from
Jul 17, 2025
Merged

Only build dependencies once on deploy command #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/datacustomcode/deploy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,6 @@ def deploy_full(
access_token = _retrieve_access_token(credentials)

# prepare payload
prepare_dependency_archive(directory)
verify_data_transform_config(directory)

# create deployment and upload payload
Expand Down
6 changes: 0 additions & 6 deletions tests/test_deploy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -737,7 +737,6 @@ def test_create_data_transform(self, mock_make_api_call, mock_get_config):

class TestDeployFull:
@patch("datacustomcode.deploy._retrieve_access_token")
@patch("datacustomcode.deploy.prepare_dependency_archive")
@patch("datacustomcode.deploy.verify_data_transform_config")
@patch("datacustomcode.deploy.create_deployment")
@patch("datacustomcode.deploy.zip")
Expand All @@ -752,7 +751,6 @@ def test_deploy_full(
mock_zip,
mock_create_deployment,
mock_verify_config,
mock_prepare,
mock_retrieve_token,
):
"""Test full deployment process."""
Expand Down Expand Up @@ -782,7 +780,6 @@ def test_deploy_full(

# Assertions
mock_retrieve_token.assert_called_once_with(credentials)
mock_prepare.assert_called_once_with("/test/dir")
mock_verify_config.assert_called_once_with("/test/dir")
mock_create_deployment.assert_called_once_with(access_token, metadata)
mock_zip.assert_called_once_with("/test/dir")
Expand Down Expand Up @@ -815,7 +812,6 @@ def test_run_data_transform(self, mock_make_api_call):

class TestDeployFullWithDockerIntegration:
@patch("datacustomcode.deploy._retrieve_access_token")
@patch("datacustomcode.deploy.prepare_dependency_archive")
@patch("datacustomcode.deploy.verify_data_transform_config")
@patch("datacustomcode.deploy.create_deployment")
@patch("datacustomcode.deploy.zip")
Expand All @@ -832,7 +828,6 @@ def test_deploy_full_happy_path(
mock_zip,
mock_create_deployment,
mock_verify_config,
mock_prepare,
mock_retrieve_token,
):
"""Test full deployment process with Docker dependency building."""
Expand Down Expand Up @@ -865,7 +860,6 @@ def test_deploy_full_happy_path(

# Assertions
mock_retrieve_token.assert_called_once_with(credentials)
mock_prepare.assert_called_once_with("/test/dir") # Docker dependency building
mock_verify_config.assert_called_once_with("/test/dir")
mock_create_deployment.assert_called_once_with(access_token, metadata)
mock_zip.assert_called_once_with("/test/dir")
Expand Down