Merge pull request #492 from Rocko1204/feat/additional-fields-package…

…-version feat: additional fields for package version result (VersionNumber, CodeCoverage)
forcedotcom · Apr 5, 2024 · 9296f90 · 9296f90
2 parents 8f68b44 + c4375d2
commit 9296f90
Show file tree

Hide file tree

Showing 5 changed files with 61 additions and 2 deletions.
diff --git a/src/interfaces/packagingInterfacesAndType.ts b/src/interfaces/packagingInterfacesAndType.ts
@@ -75,6 +75,8 @@ export type PackageVersionCreateRequestResult = {
   CreatedDate: string;
   HasMetadataRemoved: boolean | null;
   HasPassedCodeCoverageCheck: boolean | null;
+  CodeCoverage: number | null;
+  VersionNumber: string | null;
   CreatedBy: string;
   ConvertedFromVersionId: string | null;
 };

diff --git a/src/package/packageVersionCreateRequest.ts b/src/package/packageVersionCreateRequest.ts
@@ -20,7 +20,8 @@ Messages.importMessagesDirectory(__dirname);
 const messages = Messages.loadMessages('@salesforce/packaging', 'package_version_create');
 
 const QUERY =
-  'SELECT Id, Status, Package2Id, Package2.Name, Package2VersionId, Package2Version.SubscriberPackageVersionId, Package2Version.HasPassedCodeCoverageCheck, Tag, Branch, ' +
+  'SELECT Id, Status, Package2Id, Package2.Name, Package2VersionId, Package2Version.SubscriberPackageVersionId, Package2Version.HasPassedCodeCoverageCheck,Package2Version.CodeCoverage, Tag, Branch, ' +
+  'Package2Version.MajorVersion, Package2Version.MinorVersion, Package2Version.PatchVersion, Package2Version.BuildNumber, ' +
   'CreatedDate, Package2Version.HasMetadataRemoved, CreatedById, IsConversionRequest, Package2Version.ConvertedFromVersionId ' +
   'FROM Package2VersionCreateRequest ' +
   '%s' + // WHERE, if applicable
@@ -66,7 +67,15 @@ async function query(query: string, connection: Connection): Promise<PackageVers
     Schema & {
       Package2Version: Pick<
         PackagingSObjects.Package2Version,
-        'HasMetadataRemoved' | 'SubscriberPackageVersionId' | 'ConvertedFromVersionId' | 'HasPassedCodeCoverageCheck'
+        | 'HasMetadataRemoved'
+        | 'SubscriberPackageVersionId'
+        | 'ConvertedFromVersionId'
+        | 'HasPassedCodeCoverageCheck'
+        | 'CodeCoverage'
+        | 'MajorVersion'
+        | 'MinorVersion'
+        | 'PatchVersion'
+        | 'BuildNumber'
       >;
     } & {
       Package2: Pick<PackagingSObjects.Package2, 'Name'>;
@@ -85,6 +94,14 @@ async function query(query: string, connection: Connection): Promise<PackageVers
     Error: [],
     CreatedDate: formatDate(new Date(record.CreatedDate)),
     HasMetadataRemoved: record.Package2Version != null ? record.Package2Version.HasMetadataRemoved : null,
+    CodeCoverage:
+      record.Package2Version?.CodeCoverage != null
+        ? record.Package2Version.CodeCoverage.apexCodeCoveragePercentage
+        : null,
+    VersionNumber:
+      record.Package2Version != null
+        ? `${record.Package2Version.MajorVersion}.${record.Package2Version.MinorVersion}.${record.Package2Version.PatchVersion}.${record.Package2Version.BuildNumber}`
+        : null,
     HasPassedCodeCoverageCheck:
       record.Package2Version != null ? record.Package2Version.HasPassedCodeCoverageCheck : null,
     CreatedBy: record.CreatedById,

diff --git a/test/package/packageConvert.test.ts b/test/package/packageConvert.test.ts
@@ -241,6 +241,8 @@ describe('packageConvert', () => {
       Package2Id: '0Ho4p0000004DdnCAE',
       Package2Name: null,
       HasPassedCodeCoverageCheck: null,
+      CodeCoverage: null,
+      VersionNumber: null,
       Package2VersionId: '05i4p0000004H7lAAE',
       Status: 'Success',
       SubscriberPackageVersionId: null,
@@ -261,6 +263,8 @@ describe('packageConvert', () => {
           Error: [],
           HasMetadataRemoved: null,
           HasPassedCodeCoverageCheck: null,
+          CodeCoverage: null,
+          VersionNumber: null,
           Id: '0Ho3i000000Gmj6YYa',
           Package2Id: undefined,
           Package2Name: null,

diff --git a/test/package/packageTest.nut.ts b/test/package/packageTest.nut.ts
@@ -45,6 +45,8 @@ const VERSION_CREATE_RESPONSE_KEYS = [
   'CreatedDate',
   'HasMetadataRemoved',
   'HasPassedCodeCoverageCheck',
+  'CodeCoverage',
+  'VersionNumber',
   'CreatedBy',
   'ConvertedFromVersionId',
 ];

diff --git a/test/package/packageVersionCreate.test.ts b/test/package/packageVersionCreate.test.ts
@@ -161,6 +161,8 @@ describe('Package Version Create', () => {
       'Error',
       'HasMetadataRemoved',
       'HasPassedCodeCoverageCheck',
+      'CodeCoverage',
+      'VersionNumber',
       'Id',
       'Package2Id',
       'Package2Name',
@@ -191,6 +193,8 @@ describe('Package Version Create', () => {
       'Error',
       'HasMetadataRemoved',
       'HasPassedCodeCoverageCheck',
+      'CodeCoverage',
+      'VersionNumber',
       'Id',
       'Package2Id',
       'Package2Name',
@@ -219,6 +223,8 @@ describe('Package Version Create', () => {
       'Error',
       'HasMetadataRemoved',
       'HasPassedCodeCoverageCheck',
+      'CodeCoverage',
+      'VersionNumber',
       'Id',
       'Package2Id',
       'Package2Name',
@@ -251,6 +257,8 @@ describe('Package Version Create', () => {
       'Error',
       'HasMetadataRemoved',
       'HasPassedCodeCoverageCheck',
+      'CodeCoverage',
+      'VersionNumber',
       'Id',
       'Package2Id',
       'Package2Name',
@@ -281,6 +289,8 @@ describe('Package Version Create', () => {
       'Error',
       'HasMetadataRemoved',
       'HasPassedCodeCoverageCheck',
+      'CodeCoverage',
+      'VersionNumber',
       'Id',
       'Package2Id',
       'Package2Name',
@@ -310,6 +320,8 @@ describe('Package Version Create', () => {
       'Error',
       'HasMetadataRemoved',
       'HasPassedCodeCoverageCheck',
+      'CodeCoverage',
+      'VersionNumber',
       'Id',
       'Package2Id',
       'Package2Name',
@@ -340,6 +352,8 @@ describe('Package Version Create', () => {
       'Error',
       'HasMetadataRemoved',
       'HasPassedCodeCoverageCheck',
+      'CodeCoverage',
+      'VersionNumber',
       'Id',
       'Package2Id',
       'Package2Name',
@@ -363,6 +377,8 @@ describe('Package Version Create', () => {
       'Error',
       'HasMetadataRemoved',
       'HasPassedCodeCoverageCheck',
+      'CodeCoverage',
+      'VersionNumber',
       'Id',
       'Package2Id',
       'Package2Name',
@@ -410,6 +426,8 @@ describe('Package Version Create', () => {
       'Error',
       'HasMetadataRemoved',
       'HasPassedCodeCoverageCheck',
+      'CodeCoverage',
+      'VersionNumber',
       'Id',
       'Package2Id',
       'Package2Name',
@@ -457,6 +475,8 @@ describe('Package Version Create', () => {
       'Error',
       'HasMetadataRemoved',
       'HasPassedCodeCoverageCheck',
+      'CodeCoverage',
+      'VersionNumber',
       'Id',
       'Package2Id',
       'Package2Name',
@@ -502,6 +522,8 @@ describe('Package Version Create', () => {
       'Error',
       'HasMetadataRemoved',
       'HasPassedCodeCoverageCheck',
+      'CodeCoverage',
+      'VersionNumber',
       'Id',
       'Package2Id',
       'Package2Name',
@@ -526,6 +548,8 @@ describe('Package Version Create', () => {
       'Error',
       'HasMetadataRemoved',
       'HasPassedCodeCoverageCheck',
+      'CodeCoverage',
+      'VersionNumber',
       'Id',
       'Package2Id',
       'Package2Name',
@@ -550,6 +574,8 @@ describe('Package Version Create', () => {
       'Error',
       'HasMetadataRemoved',
       'HasPassedCodeCoverageCheck',
+      'CodeCoverage',
+      'VersionNumber',
       'Id',
       'Package2Id',
       'Package2Name',
@@ -579,6 +605,8 @@ describe('Package Version Create', () => {
       'Error',
       'HasMetadataRemoved',
       'HasPassedCodeCoverageCheck',
+      'CodeCoverage',
+      'VersionNumber',
       'Id',
       'Package2Id',
       'Package2Name',
@@ -782,6 +810,8 @@ describe('Package Version Create', () => {
       'Error',
       'HasMetadataRemoved',
       'HasPassedCodeCoverageCheck',
+      'CodeCoverage',
+      'VersionNumber',
       'Id',
       'Package2Id',
       'Package2Name',
@@ -850,6 +880,8 @@ describe('Package Version Create', () => {
       'Error',
       'HasMetadataRemoved',
       'HasPassedCodeCoverageCheck',
+      'CodeCoverage',
+      'VersionNumber',
       'Id',
       'Package2Id',
       'Package2Name',
@@ -930,6 +962,8 @@ describe('Package Version Create', () => {
       'Error',
       'HasMetadataRemoved',
       'HasPassedCodeCoverageCheck',
+      'CodeCoverage',
+      'VersionNumber',
       'Id',
       'Package2Id',
       'Package2Name',