feat: set additional fields to PackageVersionCreateRequestResult #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This is the same as PR #466 from @Rocko1204 with the addition of some test fixes that were missed in that PR.
Thank you for the PR @Rocko1204 !!!
Add the Package2.Name and Coverage Check to the PackageVersionCreateRequestResult Output.
Advantage:
The package name is in the lifecycle hooks and so we can use this info to make checks in the project json file.
I'm currently converting our build job (https://github.com/dxatscale/sfpowerscripts/tree/main) to lifecycle hooks and then we would save ourselves having to search for the package name. The coverage check is in the output as well , so we need no additional checks for result <> 75%.
@W-14811085@