Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: better error handling when installing packages #580

Merged
merged 4 commits into from
May 30, 2024

Conversation

shetzel
Copy link
Contributor

@shetzel shetzel commented May 28, 2024

Changes error handling to either re-throw the original message, or throw a new error using the old error as context.

GH Issue: forcedotcom/cli#2882
@W-15832085@

@iowillhoit
Copy link
Contributor

QA NOTES

Install key not passed

  • 🟢 Before: The subscriber package version 04tAAAAAAAAAAAAAAA is invalid, no subscriber package version record found.
  • 🟢 After: Please provide installationkey when querying against SubscriberPackageVersion that is protected by installationkey

Install key incorrect

  • 🟢 Before: The subscriber package version 04tAAAAAAAAAAAAAAA is invalid, no subscriber package version record found.
  • 🟢 After: Invalid InstallationKey for SubscriberPackageVersion

Error message is more clear when using publish-wait

Install key not passed (with --publish-wait)

  • 🟢 Before:
Error (1): The subscriber package version is not fully available.

Try this:

Please provide installationkey when querying against SubscriberPackageVersion that is protected by installationkey
  • 🟢 After: Please provide installationkey when querying against SubscriberPackageVersion that is protected by installationkey

Install key incorrect (with --publish-wait)

  • 🟢 Before:
Error (1): The subscriber package version is not fully available.

Try this:

Invalid InstallationKey for SubscriberPackageVersion
  • 🟢 After: Invalid InstallationKey for SubscriberPackageVersion

@iowillhoit iowillhoit merged commit 3eee012 into main May 30, 2024
14 checks passed
@iowillhoit iowillhoit deleted the sh/better-error-handling branch May 30, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants