fix: adds file extension to apex class and apex trigger #342
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #309
@W-14481595@
What does this PR do?
Add file extension to code coverage entries.
With this solution, the Tooling API team won't need to change the api to include the file extension when querying theApexCodeCoverageAggregate object.
What issues does this PR fix or reference?
forcedotcom/cli#1813
BEFORE
because the file extension was not present, the code coverage for classes could be overwritten by the codecoverage of triggers, when both had the same name. Moreover, all code coverage entries were treated as coverage for classes, disregarding the existence of triggers at all.
{
"no-map/Lead":{
"fnMap":{},
"branchMap":{},
"path":"no-map/Lead"
...
}
}
AFTER
Now both code coverage for apex class and triggers exist, and one can't overwrite the other.
{
"no-map/Lead.cls":{
"fnMap":{},
"branchMap":{},
"path":"no-map/Lead.cls"
...
},
"no-map/Lead.trigger":{
"fnMap":{},
"branchMap":{},
"path":"no-map/Lead.trigger"
...
}
}
I attached an output when running these changes in a sandbox that has lots of apex classes and triggers
coverage.zip
In this PR Im also enabling developers to quickly run mocha tests using a vscode extension called Mocha Test Explorer.
without this change Mocha Test Explorer features won't work and developers will have to run tests using a terminal