Sign Apex Plugin (@W-7566604) #43
Conversation
AnanyaJha
force-pushed
the
aj/signPlugin
branch
from
bc9ab77 to
9c20500
Compare
|
re: standup |
| @@ -120,6 +137,19 @@ jobs: | |||
| export RELEASE_TAG="$(node -pe "require('./packages/apex-node/package.json').version")" | |||
| git tag v${RELEASE_TAG} | |||
| git push --tags | |||
| publish-plugin-apex: | |||
There was a problem hiding this comment.
One thing that's not good with this approach is that every publish job independently bumps the package version. This will cause the package versions to be out of sync every time we publish. We should bump the version once and then kick off publishing the packages.
There was a problem hiding this comment.
Are we going to keep version number in apex-node the same as plugin? I think it has been 0.0.x
There was a problem hiding this comment.
which is different from what we use in templates (49.x.x), but I think version sync still makes sense
There was a problem hiding this comment.
since apex-node is already a few versions ahead of the plugin, would we just bump the plugin's version number up to 0.0.5? (or whatever the current version of apex-node is)
There was a problem hiding this comment.
When we bump the versions, I think we'd also need to update the version of the library dependency in the plugin @AnanyaJha
There was a problem hiding this comment.
yeah make senses to me to sync with whatever the current version of apex-node is. Let's bump apex-node and find out the version, then sync plugin-apex to that version (npm version).
There was a problem hiding this comment.
Lerna takes care of updating all the references needed, you just need to run the version update part through lerna
There was a problem hiding this comment.
yes, we discussed that offline and it's been taken care of by lerna (yarn bump-versions).
There was a problem hiding this comment.
Also currently library & plugin version are in sync so we don't need to make any changes
| - run-win-tests | ||
| - node-latest | ||
| - node-12 | ||
| - node-10 |
There was a problem hiding this comment.
@AnanyaJha After rebasing, this is the change that Xiaoyi and I want to add.
| - node-10 | |
| - node-10 | |
| - hold |
There was a problem hiding this comment.
Note that we'll also need to add prepublish and hold to this requires list for publish-plugin-apex as well.
package.json
Outdated
| @@ -34,5 +34,6 @@ | |||
| }, | |||
| "publishConfig": { | |||
There was a problem hiding this comment.
I think we can also remove publishConfig here
.circleci/config.yml
Outdated
| publish-apex-node: | ||
| <<: *defaults | ||
| steps: | ||
| - set-npmrc |
There was a problem hiding this comment.
can remove set-npmrc here too.
There was a problem hiding this comment.
For your reference, the script here https://circleci.com/orbs/registry/orb/salesforce/npm-release-management#commands-publish sets the npmrc
AnanyaJha
force-pushed
the
aj/signPlugin
branch
from
ae38f60 to
417f47c
Compare
What does this PR do?
This PR takes care of signing the apex plugin. Uses the latest version of the orb.
What issues does this PR fix or reference?
@W-7566604@