Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several Enhancements to LSP #21

Merged
merged 1 commit into from
Oct 26, 2020
Merged

Conversation

billyma
Copy link
Collaborator

@billyma billyma commented Oct 26, 2020

This is an attempt to fixes forcedotcom/salesforcedx-vscode-slds#61.

  1. Add checks to include only lightning components related files while creating the bundle

  2. Add checks to shortcut operation if the request is cancelled.

@billyma billyma requested a review from ambreeen October 26, 2020 00:42
@billyma billyma changed the title Several Enhancement to LSP Several Enhancements to LSP Oct 26, 2020
Copy link
Contributor

@ambreeen ambreeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor question but looks good to me.

You can update the LSP and core versions here if you want.

return false;
}

private static List<String> SUPPORTED_FILE_EXTENSIONS = ImmutableList.of(".html", ".js", ".css", ".cmp", ".app");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In what case are folks using .app files for lwc apps?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.app is for Aura Application

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks.

@ambreeen ambreeen merged commit 0bb7484 into forcedotcom:master Oct 26, 2020
@billyma billyma deleted the unable-to-start branch February 22, 2021 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LOVE the Validator! Why Does It Sometimes Not Run?
2 participants