Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce Memory Footprint associated with LSP #26

Merged
merged 1 commit into from
Mar 4, 2021
Merged

Reduce Memory Footprint associated with LSP #26

merged 1 commit into from
Mar 4, 2021

Conversation

billyma
Copy link
Collaborator

@billyma billyma commented Feb 26, 2021

Reduce Memory in the following area:

  • Cache Rule.getStylesWithAnnotationType result
  • Restructure the code to use Bundle as an input
  • Collapse common properties of SLDSValidator into a single bean, TokenRegistry

ambreeen
ambreeen approved these changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@ambreeen ambreeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks for making these changes!

@billyma billyma merged commit 25f4430 into forcedotcom:master Mar 4, 2021
@billyma billyma deleted the reduce-memory-footprint branch March 4, 2021 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambreeen ambreeen ambreeen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@billyma @ambreeen