Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: one step test debugging #2804

Merged
merged 11 commits into from
Jan 8, 2021
Merged

feat: one step test debugging #2804

merged 11 commits into from
Jan 8, 2021

Conversation

rcoringrato-sfdc
Copy link
Contributor

@rcoringrato-sfdc rcoringrato-sfdc commented Dec 9, 2020

What does this PR do?

  • Simplified replay debugger work flow when running Apex tests

This PR adds actions to test classes and test methods in the Apex test view that start a test run with trace flags enabled. The resultant debug log from the run is retrieved and a debug session started using the log. Subsequent PRs will add in breakpoint/checkpoint verification, and a codelens to allow initiation of the session from an apex test class context.

What issues does this PR fix or reference?

@W-7748704@

@rcoringrato-sfdc rcoringrato-sfdc requested a review from a team as a code owner December 9, 2020 05:13
@rcoringrato-sfdc rcoringrato-sfdc marked this pull request as draft December 9, 2020 05:14
@codecov
Copy link

codecov bot commented Dec 9, 2020

Codecov Report

Merging #2804 (3a33b80) into develop (8c13484) will increase coverage by 0.07%.
The diff coverage is 83.62%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2804      +/-   ##
===========================================
+ Coverage    76.26%   76.34%   +0.07%     
===========================================
  Files          274      277       +3     
  Lines        10496    10611     +115     
  Branches      1197     1216      +19     
===========================================
+ Hits          8005     8101      +96     
- Misses        2152     2162      +10     
- Partials       339      348       +9     
Impacted Files Coverage Δ
...de-apex/src/commands/forceApexTestRunCodeAction.ts 82.60% <50.00%> (-1.49%) ⬇️
...edx-vscode-apex-replay-debugger/src/utils/index.ts 75.00% <75.00%> (ø)
...e-apex-replay-debugger/src/commands/quickLaunch.ts 83.92% <83.92%> (ø)
...de-apex-replay-debugger/src/commands/traceFlags.ts 86.27% <86.27%> (ø)
...-replay-debugger/src/commands/launchFromLogFile.ts 50.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c13484...3a33b80. Read the comment docs.

@rcoringrato-sfdc rcoringrato-sfdc marked this pull request as ready for review December 15, 2020 16:36

export const LibraryCommandletExecutor =
sfdxCoreExports.LibraryCommandletExecutor;
export const notificationService = sfdxCoreExports.notificationService;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -62,5 +62,12 @@ export const messages = {
'Retrieved line breakpoint info from language server',
language_client_not_ready:
'Unable to retrieve breakpoint info from language server, language server is not ready',
unable_to_retrieve_org_info: 'Unable to retrieve OrgInfo'
unable_to_retrieve_org_info: 'Unable to retrieve OrgInfo',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lcampos @rcoringrato-sfdc - where does this message show up? Would like to rewrite it; potentially provide information to recover.

@@ -24,6 +24,9 @@
"Debuggers"
],
"dependencies": {
"@salesforce/apex-node": "0.1.4",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's also make sure to update the apex-node version to the one that includes the auth issue fix so we don't run into that while running tests here

@rcoringrato-sfdc rcoringrato-sfdc merged commit b76c48d into develop Jan 8, 2021
@rcoringrato-sfdc rcoringrato-sfdc deleted the rc/replay-flow branch January 8, 2021 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants