Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove manual listing of palette commands #2848

Merged
merged 6 commits into from
Jan 11, 2021
Merged

Conversation

ekapner
Copy link
Contributor

@ekapner ekapner commented Jan 7, 2021

What does this PR do?

Per conversation with Stephanie, we have decided to no longer manually document every palette command. So I removed the Available Commands section in both the English and Japanese versions of the vscode-commands article.

What issues does this PR fix or reference?

@W-8550600@

@ekapner ekapner requested a review from a team as a code owner January 7, 2021 21:34
Change title article title because it's no longer a "reference"
Update title for command reference to Command Palette
@codecov
Copy link

codecov bot commented Jan 7, 2021

Codecov Report

Merging #2848 (b2af755) into develop (b76c48d) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2848      +/-   ##
===========================================
- Coverage    76.34%   76.33%   -0.01%     
===========================================
  Files          277      277              
  Lines        10611    10611              
  Branches      1216     1216              
===========================================
- Hits          8101     8100       -1     
  Misses        2162     2162              
- Partials       348      349       +1     
Impacted Files Coverage Δ
...forcedx-vscode-core/src/channels/channelService.ts 81.81% <0.00%> (-2.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b76c48d...b2af755. Read the comment docs.

@ekapner
Copy link
Contributor Author

ekapner commented Jan 8, 2021

@smaddox-sf - did you want to take a look? Pretty straight forward. Just removing the Available Commands section as discussed.

@ekapner ekapner merged commit e5b3fdc into develop Jan 11, 2021
@ekapner ekapner deleted the ekapner-remove-commands branch January 11, 2021 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants