fix: unknown exception with deploy/retrieve #3178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brpowell
commented
Apr 26, 2021
Comment on lines
+16
to
+17
| e.message = e.message.replace(getRootWorkspacePath(), ''); | ||
| return e; |
There was a problem hiding this comment.
Much easier and less destructive
jag-j
approved these changes
Apr 26, 2021
Codecov Report
@@ Coverage Diff @@
## develop #3178 +/- ##
===========================================
- Coverage 76.01% 76.00% -0.02%
===========================================
Files 276 276
Lines 10403 10398 -5
Branches 1219 1218 -1
===========================================
- Hits 7908 7903 -5
Misses 2155 2155
Partials 340 340
Continue to review full report at Codecov.
|
sfsholden
approved these changes
Apr 26, 2021
lukecotter
pushed a commit
to lukecotter/salesforcedx-vscode
that referenced
this pull request
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Surfaces the original error instead of "Unknown Exception". While this doesn't exactly fix underlying issues if there are some, we or the user at least can triage what's going on.
What issues does this PR fix or reference?
#3137, @W-9178716@
Functionality Before
"Unknown Exception" message reported for any issues that are not TypeInferenceErrors
Functionality After
Original errors are now surfaced to make triaging easier.