Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update default debug port #3272

Merged
merged 1 commit into from
May 26, 2021
Merged

fix: update default debug port #3272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/salesforcedx-vscode-core/src/commands/functions/forceFunctionStart.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ export class ForceFunctionStartExecutor extends SfdxCommandletExecutor<string> {
);

execution.stdoutSubject.subscribe(data => {
if (data.toString().includes('Ready to process signals')) {
if (data.toString().includes('Debugger running on port')) {
progress.complete();
taskViewService.removeTask(task);
notificationService
Expand Down
2 changes: 1 addition & 1 deletion packages/salesforcedx-vscode-core/src/commands/functions/types/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export const FUNCTION_DEFAULT_PORT = 8080;
/**
* Default debug port of a locally running function
*/
export const FUNCTION_DEFAULT_DEBUG_PORT = 9222;
export const FUNCTION_DEFAULT_DEBUG_PORT = 9229;

/**
* Functions Payload pattern
Expand Down
2 changes: 1 addition & 1 deletion ...forcedx-vscode-core/test/vscode-integration/commands/functions/forceFunctionStart.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ describe('Force Function Start', () => {

await forceFunctionStart(srcUri);

mockExecution.stdoutSubject.next('Ready to process signals');
mockExecution.stdoutSubject.next('Debugger running on port');
assert.calledOnce(logMetricStub);
assert.calledWith(logMetricStub, 'force_function_start', mockStartTime);
});
Expand Down