Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add command to logout of default org #3428

Merged
merged 7 commits into from
Jul 23, 2021
Merged

Conversation

rcoringrato-sfdc
Copy link
Contributor

@rcoringrato-sfdc rcoringrato-sfdc commented Jul 19, 2021

What does this PR do?

Add a command SDFX: Log Out from Default Org to logout from a projects default org.

What issues does this PR fix or reference?

@ W-9466522@

Functionality After

Confirmation dialog when logging out of default scratch org:
ScratchOrgLogoutConfirm3

@rcoringrato-sfdc rcoringrato-sfdc requested a review from a team as a code owner July 19, 2021 16:45
@@ -269,6 +270,11 @@ export const messages = {
auth_custom_label: 'Custom',
auth_custom_detail: 'Enter a custom login URL',
auth_invalid_url: 'URL must begin with http:// or https://',
auth_logout_scratch_prompt:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbudhirajadoc Prompt and options for scratch org confirmation dialog.

Copy link
Contributor

@sbudhirajadoc sbudhirajadoc Jul 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can I see a screen of this confirmation dialog please? I am not able to figure out where the label "Custom" will show up. The word alone doesn't seem super helpful as a label...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbudhirajadoc I updated the description with an image of the confirmation dialog.

}

async function removeUsername(username: string) {
await forceConfigSet('');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a general musing - can we eventually replace the call to the sfdx force:config:set command with a direct call to @salesforce/core?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnanyaJha Yes, I was planning to convert the spike story into a story to do that. I felt it was out of scope for this work.

@rcoringrato-sfdc rcoringrato-sfdc merged commit b6747f2 into develop Jul 23, 2021
@rcoringrato-sfdc rcoringrato-sfdc deleted the rc/logout branch July 23, 2021 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants