-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add command to logout of default org #3428
Conversation
@@ -269,6 +270,11 @@ export const messages = { | |||
auth_custom_label: 'Custom', | |||
auth_custom_detail: 'Enter a custom login URL', | |||
auth_invalid_url: 'URL must begin with http:// or https://', | |||
auth_logout_scratch_prompt: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sbudhirajadoc Prompt and options for scratch org confirmation dialog.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can I see a screen of this confirmation dialog please? I am not able to figure out where the label "Custom" will show up. The word alone doesn't seem super helpful as a label...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sbudhirajadoc I updated the description with an image of the confirmation dialog.
} | ||
|
||
async function removeUsername(username: string) { | ||
await forceConfigSet(''); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a general musing - can we eventually replace the call to the sfdx force:config:set
command with a direct call to @salesforce/core
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AnanyaJha Yes, I was planning to convert the spike story into a story to do that. I felt it was out of scope for this work.
What does this PR do?
Add a command
SDFX: Log Out from Default Org
to logout from a projects default org.What issues does this PR fix or reference?
@ W-9466522@
Functionality After
Confirmation dialog when logging out of default scratch org: