Pr/3429 use functions lib to create functions #3476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jag-j
reviewed
Aug 5, 2021
| @@ -127,7 +124,7 @@ export class FunctionInfoGatherer implements ParametersGatherer<FunctionInfo> { | |||
| } | |||
|
|
|||
| const language = await vscode.window.showQuickPick( | |||
| [LANGUAGE_JAVA, LANGUAGE_JAVASCRIPT], | |||
| [LANGUAGE_JAVA, LANGUAGE_JAVASCRIPT, LANGUAGE_TYPESCRIPT], | |||
There was a problem hiding this comment.
I missed to see this in Yousef's review. Don't think we want to support typescript yet. This can be removed.
There was a problem hiding this comment.
@jag-sfdc Can you confirm that we'll keep it as is?
There was a problem hiding this comment.
Yes, we will keep this as is.
jag-j
approved these changes
Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replace CLI usage with library for Create Function, reducing execution time greatly. Additionally, add typescript support
What issues does this PR fix or reference?
@W-9709809@