Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Generating manifest file in Org Browser results in an error #3818

Merged
merged 7 commits into from
Feb 14, 2022

Conversation

RitamAgrawal
Copy link
Member

What does this PR do?

This PR removes the command Generate Manifest File, which was appearing on right-clicking the components listed under metadata types in the Org Browser e.g. AccountController component listed under Apex Classes metadata type.

What issues does this PR fix or reference?

#3801 , @W-10534623@

Functionality Before

Command Generate manifest file was appearing on right clicking the components listed within metadata types and the command was not executable.
Screen Shot 2022-02-10 at 11 26 57 AM

Functionality After

The command 'Generate Manifest file' doesn't appear on right clicking at components listed within metadata types

@RitamAgrawal RitamAgrawal requested a review from a team as a code owner February 10, 2022 19:28
},
{
"command": "sfdx.create.manifest",
"when": "view == metadata && viewItem == component"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A for my education question...why do we sometimes have the "when": "false" and other times don't?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RitamAgrawal RitamAgrawal merged commit c3a57c0 into develop Feb 14, 2022
@RitamAgrawal RitamAgrawal deleted the ra/remove_ob_generate_manifest_command branch February 14, 2022 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants