Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove visibility of Diff Folder from command palette #3843

Merged
merged 3 commits into from
Feb 17, 2022

Conversation

floralan
Copy link
Contributor

@floralan floralan commented Feb 15, 2022

What does this PR do?

Remove "SFDX: Diff Folder Against Org" from Command Palette:

What issues does this PR fix or reference?

@W-9426693

Functionality Before "SFDX: Diff Folder Against Org" is visible on Command Palette outside of a SFDX project:

image

Functionality After

"SFDX: Diff Folder Against Org" is removed from Command Palette.

@floralan floralan marked this pull request as ready for review February 15, 2022 21:36
@floralan floralan requested a review from a team as a code owner February 15, 2022 21:36
@floralan floralan requested a review from randi274 February 15, 2022 21:36
@floralan floralan changed the title fix: Diff related command showing in command palette fix: Remove/ Add visibility of Diff related commands on command palette Feb 15, 2022
@RitamAgrawal
Copy link
Member

@floralan When project is not connected to any org, is it expected to show SFDX: Diff File against Org command in the command palette? Like it's showing now:
Screen Shot 2022-02-15 at 3 03 16 PM

@floralan
Copy link
Contributor Author

floralan commented Feb 15, 2022

@RitamAgrawal When a SFDX project is not opened, we do not expect "SFDX: Diff File Against Org" showing on Command Palette. Only these three SFDX commands should be displayed here.
image

@floralan
Copy link
Contributor Author

@RitamAgrawal "false" means do not show this command on Command Palette in any situation.

@floralan floralan changed the title fix: Remove/ Add visibility of Diff related commands on command palette fix: Remove visibility of Diff Folder from command palette Feb 16, 2022
@floralan floralan merged commit 3e3eb69 into develop Feb 17, 2022
@floralan floralan deleted the fl/fix_diff_visible_outside_project branch February 17, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants