Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: the SFDX: Create Project command now removes leading and trailing whitespaces from the project name #3950

Merged
merged 29 commits into from
Apr 7, 2022
Merged

fix: the SFDX: Create Project command now removes leading and trailing whitespaces from the project name #3950

merged 29 commits into from
Apr 7, 2022

Conversation

klewis-sfdc
Copy link
Contributor

@klewis-sfdc klewis-sfdc commented Mar 24, 2022 •
edited
Loading

fix #2605

What does this PR do?

Leading and trailing white spaces will now get stripped when using the SFDX: Create Project command

What issues does this PR fix or reference?

#2605, @W-8190305@

Functionality Before

The SFDX: Create Project command allows leading and trailing whitespaces in the project name.

Functionality After

The SFDX: Create Project command strips leading and trailing whitespaces from the project name.

@klewis-sfdc
feat: strip leading and trailing whitespaces from Project Name when u…
993d1f2 
…sing SFDX: Create Project

Leading and trailing white spaces will now get stripped when using the SFDX: Create Project command

fix #2605
@klewis-sfdc klewis-sfdc requested a review from a team as a code owner March 24, 2022 20:00
@klewis-sfdc klewis-sfdc requested a review from randi274 March 24, 2022 20:00
@klewis-sfdc klewis-sfdc marked this pull request as draft March 24, 2022 20:15
gbockus-sf
gbockus-sf reviewed Mar 24, 2022
View reviewed changes
Copy link
Contributor

@gbockus-sf gbockus-sf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff 👍 a few suggestions in there

klewis-sfdc and others added 10 commits March 24, 2022 16:19
@trinasfdx trinasfdx added the status:in review pr/issue is being reviewed label Apr 1, 2022
@klewis-sfdc klewis-sfdc removed the status:in review pr/issue is being reviewed label Apr 4, 2022
@klewis-sfdc klewis-sfdc changed the title feat: strip leading and trailing whitespaces when creating an SFDX project The SFDX: Create Project command now removes leading and trailing whitespaces from the project name Apr 4, 2022
@randi274 randi274 mentioned this pull request Apr 4, 2022
Closed
@klewis-sfdc klewis-sfdc marked this pull request as ready for review April 5, 2022 20:26
@klewis-sfdc klewis-sfdc changed the title The SFDX: Create Project command now removes leading and trailing whitespaces from the project name feat: the SFDX: Create Project command now removes leading and trailing whitespaces from the project name Apr 5, 2022
gbockus-sf
gbockus-sf approved these changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@gbockus-sf gbockus-sf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍠 Looks good. Don't forget to wait for your QE to approve before hitting the button 👍

@floralan floralan requested a review from sbudhirajadoc April 6, 2022 16:37
@floralan
Copy link
Contributor

floralan commented Apr 6, 2022 •
edited
Loading

Since this is a bug fix, PR title should start with fix:, so changelog generator will categorize this into fix column in changelog. I added Sonal as the reviewer so we need wait her approval on the title to get this PR merged.

@klewis-sfdc klewis-sfdc changed the title feat: the SFDX: Create Project command now removes leading and trailing whitespaces from the project name fix: the SFDX: Create Project command now removes leading and trailing whitespaces from the project name Apr 6, 2022
@floralan
Copy link
Contributor

floralan commented Apr 7, 2022 •
edited
Loading

Used vsixes and local build to verify this PR:

✅ Verified that SFDX:Create Project command allows leading and trailing space in extensions v54.7.0
✅ Verified that, with the changes in this PR, SFDX:Create Project command automatically delete the leading and trailing space for project name.
✅ Verified that SFDX:Create Project works in the same manner for standard, empty and analytics three options.

@klewis-sfdc klewis-sfdc merged commit 257abd6 into develop Apr 7, 2022
@klewis-sfdc klewis-sfdc deleted the ken/create-project-strip-leading-trailing-whitespaces branch April 7, 2022 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffb-sfdc jeffb-sfdc jeffb-sfdc left review comments

@jag-j jag-j jag-j left review comments

@gbockus-sf gbockus-sf gbockus-sf approved these changes

@randi274 randi274 Awaiting requested review from randi274 randi274 is a code owner automatically assigned from forcedotcom/ide-experience

@sbudhirajadoc sbudhirajadoc Awaiting requested review from sbudhirajadoc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The SFDX: Create Project command allows trailing spaces for Project Name
6 participants
@klewis-sfdc @floralan @jeffb-sfdc @jag-j @gbockus-sf @trinasfdx